From owner-freebsd-stable@FreeBSD.ORG Thu Oct 23 09:18:35 2003 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C192E16A4B3 for ; Thu, 23 Oct 2003 09:18:35 -0700 (PDT) Received: from carver.gumbysoft.com (carver.gumbysoft.com [66.220.23.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 273A443FBD for ; Thu, 23 Oct 2003 09:18:35 -0700 (PDT) (envelope-from dwhite@gumbysoft.com) Received: by carver.gumbysoft.com (Postfix, from userid 1000) id 1ADBB72DA3; Thu, 23 Oct 2003 09:18:35 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by carver.gumbysoft.com (Postfix) with ESMTP id 189B872DA2; Thu, 23 Oct 2003 09:18:35 -0700 (PDT) Date: Thu, 23 Oct 2003 09:18:35 -0700 (PDT) From: Doug White To: Michail Vidiassov In-Reply-To: <20031023110929.I22874@serv.iaas.msu.ru> Message-ID: <20031023091642.M79600@carver.gumbysoft.com> References: <20031019005014.L49355@serv.iaas.msu.ru> <20031018161928.M35407@carver.gumbysoft.com> <20031022152527.W71676@carver.gumbysoft.com> <20031023110929.I22874@serv.iaas.msu.ru> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: freebsd-stable@freebsd.org Subject: Re: ACPI problem - broken debug output X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Oct 2003 16:18:35 -0000 On Thu, 23 Oct 2003, Michail Vidiassov wrote: > On Wed, 22 Oct 2003, Doug White wrote: > > > > But after I have defined ACPI_DEBUG_OUTPUT in > > > /sys/contrib/dev/acpica/acconfig.h > > > I have got broken debug output like > > > > > > Table [DSDT] - %hd Objects with %hd Devices %hd Methods %hd Regions > > > %hd Devices found containing: %hd _STA, %hd _INI methods > > > Initialized %hd/%hd Regions %hd/%hd Fields %hd/%hd Buffers %hd/%hd > > > Packages (%hd nodes) > > > > Typically, acpi debugging is enabled using a couple of loader tunables, as > > described on acpi(4). You just need to compile with ACPI_DEBUG to get the > > output functionality. I think ACPI_DEBUG_OUTPUT is some internal option > > that you shouldn't be messing with directly. > > > > No, /sys/contrib/dev/acpica/CHANGES.txt told me: > Replace ACPI_DEBUG define with ACPI_DEBUG_OUTPUT. Wonder why this change wasn't propagated to -current. This might not be relevant for the FreeBSD import. > The broken output is caused by the lack of support for > "h" (short int) optional character in the kvprintf > function, "Scaled down version of printf", residing in > /sys/kern/subr_prf.c > > Thus the solution is to replace %hd with %d in > /sys/contirb/dev/acpica/* (since short is converted to > int anyway) or enhancing kvprintf to handle "h", > to make porting from Linux easier. > > Is it worth sending a pr? Oh, this is -STABLE. Hm. That might be a problem. Go ahead and send the pr. > Sincerely, Michail > PS. BTW. acpi(4) does not mention the need to use > acpi_dsdt_type="acpi_dsdt", since it is a loader.conf > default on FreeBSD-CURRENT. But not on 4.9-??. > May be it is also worth reporting? Sure. -- Doug White | FreeBSD: The Power to Serve dwhite@gumbysoft.com | www.FreeBSD.org