From nobody Tue Aug 1 13:56:50 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RFc9W07R5z4qCtC; Tue, 1 Aug 2023 13:56:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RFc9H2Wvgz43gS; Tue, 1 Aug 2023 13:56:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690898211; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=R0XhlrQXf/xAFpd1ozIs8/JYmhzNh2MFgBrHkvAYcHM=; b=L5BaklZLaBwFrOwpo0VoZFztg4IlbshKc4BrWJpCXSa35Vh2d4CzD8WwvCbh45uvcJ6jsl A7KqUWiZETX+G4shLDkcEl9JYYCstAxCSRS2+aIK9Z0DjwGlehsFwZ6whwAbWK/veKdoIF gByoFhn2Ht3C6TEvrrYidEqqcvSwDm/729pCZMDibymyoAUFsOThhW8m+SB4uWTH6neWt7 C78tXho0XfLRLawpPPfJRVQ9VDJ1Zbcz0EmIgKiyfLK4AwZ32rsLr2CxcELHJhjbt6mwJj errfNo7havrjlZW48YYn6qo/gSe55MC4wXCTaXKeaK76pB5oSoNfc3TzB/pqWw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1690898211; a=rsa-sha256; cv=none; b=WZE2g0QD3Dm4GreTCpt4p5Xl2JBAfCVcwqSsklLVQGNIiCBn+4IovIDwGTZw91yCq8NK2H Np1jE9+HnhRTCpyrMjWRBwxWWFXyfXawrvULSL4vE0E97qO5jnV38DhN73yvvmqMO5rGkV V29gX49vLDLDLNVBUcYUkg3UVGS61Ndf+otAENVOJtvgnIWwaTa1nK3hlxxQVir7kzY6Cz MxUVJfcvGYK+HKz9rTuAqDIXpA2yHvCd4aPQKY+KZk2IkTiFFZFGzmYVHqUFU00oe1wEl3 XTKLTWtZtsBaVgBFIBK8DP1woPqDCEF74Mex4/d9HrioozAm81I1dmy8U+Uf2g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690898211; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=R0XhlrQXf/xAFpd1ozIs8/JYmhzNh2MFgBrHkvAYcHM=; b=bWQWtsFO3CfjhtjN+hEIV5EXbx3zQW6BbrxIHB/sYUT9XZNjf6jPONcPvIQ1ZFHHM0F+mr 17q05wB69RWrdogubn91wf/AvGSFxXMGOgULC+0S4TPmMxtVIDJTBP+xbmXfpLbLAQIIJL 0+muhCLfex6K5CXOI1JDkyZgkdwLa/7+lysgqwC91SWNFKcE4o1J5KFuDFvCNGyOHPI8zi XU7N6iHPSfVr+JlO187p44QZ4XbTp+UhS9WZkR18ycNvsDkxKUssE/uTicsHXu3F7QDXk2 ac4D6vxtmhSKFSlcx8q+8bgMZ/yVdJ4NMTRS7/yOQQ/snTo23mRaEE2/KuXk0w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RFc9H0YSLzg32; Tue, 1 Aug 2023 13:56:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 371DuovW098202; Tue, 1 Aug 2023 13:56:50 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 371DuoGv098201; Tue, 1 Aug 2023 13:56:50 GMT (envelope-from git) Date: Tue, 1 Aug 2023 13:56:50 GMT Message-Id: <202308011356.371DuoGv098201@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: a53a2971ac3f - stable/13 - bhyve: Stop calling pci_lintr_request() in the NVMe device model List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: a53a2971ac3fc1d0d7bea205ef13892f6b9fded4 Auto-Submitted: auto-generated The branch stable/13 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=a53a2971ac3fc1d0d7bea205ef13892f6b9fded4 commit a53a2971ac3fc1d0d7bea205ef13892f6b9fded4 Author: Mark Johnston AuthorDate: 2023-06-28 20:06:21 +0000 Commit: Mark Johnston CommitDate: 2023-08-01 13:56:16 +0000 bhyve: Stop calling pci_lintr_request() in the NVMe device model The device model effectively assumes that MSI-X is enabled (it never asserts the legacy interrupt), so any guest which relies on being able to use the legacy PCI interrupt will fail. The WIP arm64 port does not implement legacy PCI interrupts, but NVMe emulation is potentially useful there. Simply remove the call. Reviewed by: corvink, chuck, jhb Tested by: chuck MFC after: 1 month Sponsored by: Innovate UK Differential Revision: https://reviews.freebsd.org/D40731 (cherry picked from commit 13013d266e7781022fde04509670d0ce5f2ac25f) --- usr.sbin/bhyve/pci_nvme.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/usr.sbin/bhyve/pci_nvme.c b/usr.sbin/bhyve/pci_nvme.c index 9f99a39de441..4ff5243262fa 100644 --- a/usr.sbin/bhyve/pci_nvme.c +++ b/usr.sbin/bhyve/pci_nvme.c @@ -3356,8 +3356,6 @@ pci_nvme_init(struct pci_devinst *pi, nvlist_t *nvl) pci_nvme_reset(sc); - pci_lintr_request(pi); - done: return (error); }