Date: Tue, 1 Aug 2023 13:56:50 GMT From: Mark Johnston <markj@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: a53a2971ac3f - stable/13 - bhyve: Stop calling pci_lintr_request() in the NVMe device model Message-ID: <202308011356.371DuoGv098201@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=a53a2971ac3fc1d0d7bea205ef13892f6b9fded4 commit a53a2971ac3fc1d0d7bea205ef13892f6b9fded4 Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2023-06-28 20:06:21 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2023-08-01 13:56:16 +0000 bhyve: Stop calling pci_lintr_request() in the NVMe device model The device model effectively assumes that MSI-X is enabled (it never asserts the legacy interrupt), so any guest which relies on being able to use the legacy PCI interrupt will fail. The WIP arm64 port does not implement legacy PCI interrupts, but NVMe emulation is potentially useful there. Simply remove the call. Reviewed by: corvink, chuck, jhb Tested by: chuck MFC after: 1 month Sponsored by: Innovate UK Differential Revision: https://reviews.freebsd.org/D40731 (cherry picked from commit 13013d266e7781022fde04509670d0ce5f2ac25f) --- usr.sbin/bhyve/pci_nvme.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/usr.sbin/bhyve/pci_nvme.c b/usr.sbin/bhyve/pci_nvme.c index 9f99a39de441..4ff5243262fa 100644 --- a/usr.sbin/bhyve/pci_nvme.c +++ b/usr.sbin/bhyve/pci_nvme.c @@ -3356,8 +3356,6 @@ pci_nvme_init(struct pci_devinst *pi, nvlist_t *nvl) pci_nvme_reset(sc); - pci_lintr_request(pi); - done: return (error); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202308011356.371DuoGv098201>