From owner-freebsd-audit Tue Oct 24 13:39:38 2000 Delivered-To: freebsd-audit@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.100.7]) by hub.freebsd.org (Postfix) with ESMTP id 1F2C737B479 for ; Tue, 24 Oct 2000 13:39:36 -0700 (PDT) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.9.3/8.9.3) with ESMTP id QAA451772; Tue, 24 Oct 2000 16:39:31 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20001024211518.E209@lucifer.bart.nl> References: <20001024140510.G93799@lucifer.bart.nl> <20001024170054.Q93799@lucifer.bart.nl> <20001024192539.A65599@gvr.gvr.org> <20001024202942.C209@lucifer.bart.nl> <20001024211518.E209@lucifer.bart.nl> Date: Tue, 24 Oct 2000 16:39:29 -0400 To: Jeroen Ruigrok van der Werven , Guido van Rooij From: Garance A Drosihn Subject: Re: printjob.c mktemp() problem Cc: audit@FreeBSD.ORG Content-Type: text/plain; charset="us-ascii" ; format="flowed" Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG At 9:15 PM +0200 10/24/00, Jeroen Ruigrok van der Werven wrote: > >I still need to look at Garance's mention of the tempfile name which > >doesn't include a /tmp/ path. > >My new patch should also fix this case. > >Given that lpd is a daemon I didn't use warnx/errx but instead used >syslog(), but it might be that some logging is not yet fully clear what >went wrong with my patch. I'll try to test that tomorrow. > >I haven't sanitized the code further except make my changes as sane >possible as I could by myself and guidance from my mentors and peers. Oops, I didn't notice your new patch was in the same message. The new patch is not good, because the temp files should not be in /tmp. It might be best to let this particular mktemp call alone for now, and I'll fix it when I get a chance to. I'd say more, but something odd seems to be going on in our (RPI) network right now... --- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or drosih@rpi.edu Rensselaer Polytechnic Institute To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message