From owner-p4-projects@FreeBSD.ORG Mon May 1 08:58:56 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id A1A6816A404; Mon, 1 May 2006 08:58:56 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6402316A401 for ; Mon, 1 May 2006 08:58:56 +0000 (UTC) (envelope-from jb@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2F4A543D48 for ; Mon, 1 May 2006 08:58:56 +0000 (GMT) (envelope-from jb@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k418wuVp007678 for ; Mon, 1 May 2006 08:58:56 GMT (envelope-from jb@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k418wtVP007672 for perforce@freebsd.org; Mon, 1 May 2006 08:58:55 GMT (envelope-from jb@freebsd.org) Date: Mon, 1 May 2006 08:58:55 GMT Message-Id: <200605010858.k418wtVP007672@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to jb@freebsd.org using -f From: John Birrell To: Perforce Change Reviews Cc: Subject: PERFORCE change 96473 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 May 2006 08:58:56 -0000 http://perforce.freebsd.org/chv.cgi?CH=96473 Change 96473 by jb@jb_freebsd2 on 2006/05/01 08:57:59 The function callbacks occur during a syscall and they have no way to report errors, so they might as well be void functions. If they can't do what they were intended to do, the best that they can do is just shut the %$&k up. Affected files ... .. //depot/projects/dtrace/src/sys/sys/sysent.h#3 edit Differences ... ==== //depot/projects/dtrace/src/sys/sys/sysent.h#3 (text+ko) ==== @@ -42,13 +42,13 @@ typedef int sy_call_t(struct thread *, void *); /* Used by the machine dependent syscall() code. */ -typedef int (*systrace_probe_func_t)(u_int32_t, int, struct sysent *, void *); +typedef void (*systrace_probe_func_t)(u_int32_t, int, struct sysent *, void *); /* * Used by loaded syscalls to convert arguments to a DTrace array * of 64-bit arguments. */ -typedef int (*systrace_args_func_t)(void *, u_int64_t *, int *); +typedef void (*systrace_args_func_t)(void *, u_int64_t *, int *); extern systrace_probe_func_t systrace_probe_func;