From owner-freebsd-current@freebsd.org Sat Oct 3 20:36:03 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 175424374EA; Sat, 3 Oct 2020 20:36:03 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C3dt96mtRz3YFd; Sat, 3 Oct 2020 20:36:01 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-qk1-f180.google.com with SMTP id q5so7336966qkc.2; Sat, 03 Oct 2020 13:36:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M7bhWzKW2ug18zFrbqVYORCzQAf21V1hm5ZcanNTjbQ=; b=LcX68c4LpFf2ITE64V0SJzdMcO3SZEU6yfptd+pyvvONcX8CiFeQiPZe4UPcQx/bNb FQVVKIffJyTYWorK2mWGEuXI1jxHUfwQTwjyks+NbNWgy/7O3cpKqXF8pj8ZzcVmGpnP 5jzYjoDViG4hoGdJGUb552HjGFy4g5fVIT/WJ65/lHHZVC7N5/xWBkzAiMQcp+g95JZj AI04PPlV4XTIzDraD122nXuJmKLl866HngCEEe6R7U06hwwfMsQbznZh0znQe2UKMcdn z1kg0ynxcVZ/IW0KOSoBNxz89RRSXsFF4T5yH8WIu/nEDfhuI9xWgRSfUQC8+o45Ge6m mGfA== X-Gm-Message-State: AOAM531Gky8ubr82p8Z6h/Db0bpeibnUvaKnbKv9KimZmBz8b8V6NFlw k2Ht4iR+4MwsL0gccCzf3FBBd+EdaNOWjrBYoymhnKbd X-Google-Smtp-Source: ABdhPJxgfprLQs+rLXxs+OKaKhyNaCo8dpOne6ZHpnr5/9AGMAbLf/CQ2GjPLhLov8x1j6o+4oWogPCYDfb6HC8kG/Q= X-Received: by 2002:a37:67d2:: with SMTP id b201mr7914909qkc.96.1601757360113; Sat, 03 Oct 2020 13:36:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Adrian Chadd Date: Sat, 3 Oct 2020 13:35:47 -0700 Message-ID: Subject: Re: mips32 + gcc9 -- still broken To: Alexander Richardson Cc: freebsd-current , "freebsd-mips@freebsd.org" X-Rspamd-Queue-Id: 4C3dt96mtRz3YFd X-Spamd-Bar: - X-Spamd-Result: default: False [-1.52 / 15.00]; FROM_NEQ_ENVFROM(0.00)[adrian@freebsd.org,adrianchadd@gmail.com]; MAILMAN_DEST(0.00)[freebsd-current,freebsd-mips]; TO_DN_EQ_ADDR_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; NEURAL_HAM_LONG(-0.99)[-0.986]; DMARC_NA(0.00)[freebsd.org]; NEURAL_SPAM_SHORT(0.33)[0.334]; RCVD_IN_DNSWL_NONE(0.00)[209.85.222.180:from]; NEURAL_HAM_MEDIUM(-0.87)[-0.869]; FORGED_SENDER(0.30)[adrian@freebsd.org,adrianchadd@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.222.180:from]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Oct 2020 20:36:03 -0000 On Mon, 21 Sep 2020 at 00:43, Alexander Richardson wrote: > > On Mon, 21 Sep 2020, 07:38 Adrian Chadd, wrote: > >> So, the big list of unknown symbols was my fault! Whoops. >> >> i've gotten further using gcc-6.4 by fixing some of the warnings/issues >> that have crept up. >> >> Here's a review for one of them: >> >> https://reviews.freebsd.org/D26504 >> >> However, now I've hit: >> >> /usr/local/bin/mips-unknown-freebsd13.0-ld: >> >> /usr/home/adrian/work/freebsd/head-embedded/obj/mips_ap/usr/home/adrian/work/freebsd/head-embedded/src/mips.mips/tmp/usr/lib/libc++.so.1: >> undefined reference to `__atomic_fetch_sub_8' >> /usr/local/bin/mips-unknown-freebsd13.0-ld: >> >> /usr/home/adrian/work/freebsd/head-embedded/obj/mips_ap/usr/home/adrian/work/freebsd/head-embedded/src/mips.mips/tmp/usr/lib/libc++.so.1: >> undefined reference to `__atomic_load_8' >> /usr/local/bin/mips-unknown-freebsd13.0-ld: >> >> /usr/home/adrian/work/freebsd/head-embedded/obj/mips_ap/usr/home/adrian/work/freebsd/head-embedded/src/mips.mips/tmp/usr/lib/libc++.so.1: >> undefined reference to `__atomic_fetch_add_8' >> >> .. looks like we need some 64 bit atomics now in mips32 for libc++ / devd >> > > Those are now provided by compiler-rt when using clang. With GCC you'll > have to link libatomic. I had a quick look at the code in libc++ that uses > the 64-bit atomics a few weeks ago and I believe it's the futex fallback > code. The best solution would probably be to port it to use umtx but for > MIPS32 it might be fine to use a 32 bit atomic instead. > It compiled fine with a 32 bit atomic. Why's it 64 bit for everything but Linux? Can we make it a 32 bit atomic for all FreeBSD platforms? Are there ABI concerns? -adrian > > Alex > >>