From owner-svn-src-all@FreeBSD.ORG Sat Feb 14 19:59:46 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6DE403C7 for ; Sat, 14 Feb 2015 19:59:46 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2A8EFE11 for ; Sat, 14 Feb 2015 19:59:46 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t1EJxjTq063108 for ; Sat, 14 Feb 2015 19:59:45 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id t1EJxjwJ063104 for svn-src-all@freebsd.org; Sat, 14 Feb 2015 19:59:45 GMT (envelope-from bdrewery) Received: (qmail 14765 invoked from network); 14 Feb 2015 13:59:43 -0600 Received: from unknown (HELO ?10.10.1.139?) (freebsd@shatow.net@10.10.1.139) by sweb.xzibition.com with ESMTPA; 14 Feb 2015 13:59:43 -0600 Message-ID: <54DFA938.6020207@FreeBSD.org> Date: Sat, 14 Feb 2015 13:59:52 -0600 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Steven Hartland , phabric-admin@FreeBSD.org Subject: Re: Phabricator + 'Reviewed by' [was Re: svn commit: r278472 - in head/sys: netinet netinet6] References: <201502091928.t19JSC5P066293@svn.freebsd.org> <38B8D2D0-862A-4DF5-9479-8EC234CF830B@FreeBSD.org> <54DE8F32.2090500@FreeBSD.org> <54DF6709.6030204@freebsd.org> In-Reply-To: <54DF6709.6030204@freebsd.org> OpenPGP: id=6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="71KaNec92cajp8T0dhVfr0IlJNwmc4jqa" Cc: svn-src-head@freebsd.org, Randall Stewart , svn-src-all@freebsd.org, "Bjoern A. Zeeb" , src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Feb 2015 19:59:46 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --71KaNec92cajp8T0dhVfr0IlJNwmc4jqa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2/14/2015 9:17 AM, Steven Hartland wrote: >=20 > On 13/02/2015 23:56, Bryan Drewery wrote: >> On 2/9/2015 3:45 PM, Bjoern A. Zeeb wrote: >>>> Commented upon by hiren and sbruno >>>> See Phabricator D1777 for more details. >>>> >>>> Commented upon by hiren and sbruno >>>> Reviewed by: adrian, jhb and bz >>> I have not reviewed this; as a matter of fact you are aware that I >>> still wanted to do that. >>> >> Something about Phabricator is not jiving with our commit terminology.= >> This has happened before as well with other commits. I'm sure everyone= >> is good-intentioned as well. >> >> There's not 1 person on D1777 who has 'accepted' it. That is what >> warrants a 'Reviewed by' to me. >> >> It's clear to me, but seems unclear to others. I really think the >> reviewer list needs to be split up. Rather than using icons, use >> separate lists. Reviewers requested: accepted: commented: changes >> requested:. > I don't think it needs to be split up, that feels unnecessary, if > someone hasn't accepted it then they haven't review it period IMO. Yes I too think it's obvious, yet I've seen at least 2 commits where the reviewed by line was essentially a lie. It's in SVN forever now with those names stamped as reviewers. --=20 Regards, Bryan Drewery --71KaNec92cajp8T0dhVfr0IlJNwmc4jqa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJU36k4AAoJEDXXcbtuRpfPrisIALypNR5Xg4JeqeVwkRtogT/I p+gD7vk/HUNA5hg/wrin8nRB4pIKnikASihy5SnD99Wf5aS8a+Xl+rVbpyIrWtNY xrTswaA5i6TF6/Um0rJN0D5RNnL95W/33t5IcqsBBFb4peYRipqh+q9/YO7xV76N T9bAHHMsMWdoe818LKD8rdEjIbNh02m/xhrjp1BQ3dZ+bWYDKMG/PI9kRGKc1owH LMZQfsl8U0F5yQOfnVAn06kWELcqQqMhggzZGdh+4UwXLpXFndswrLgJHef8YO+d dbm8Ni++GQ/vg2GfiPjw/DmTRDmIl/i6MB8MiErbW824v93d2vBAjgT3qY6pCjo= =JhPT -----END PGP SIGNATURE----- --71KaNec92cajp8T0dhVfr0IlJNwmc4jqa--