From owner-svn-src-head@freebsd.org Sat Mar 4 21:43:23 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D5D77CF5D6B for ; Sat, 4 Mar 2017 21:43:23 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x230.google.com (mail-it0-x230.google.com [IPv6:2607:f8b0:4001:c0b::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9CA451043 for ; Sat, 4 Mar 2017 21:43:23 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x230.google.com with SMTP id 203so31705022ith.0 for ; Sat, 04 Mar 2017 13:43:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=av+uBscM2PY5+/viB0yBeC7bp/XGdO8EPjYNE08WSlw=; b=A8wlKxO3G3BgVuxFe7wa8a7pDQADUfzxN/+KS0+KHqA8C/1vacb8ZmFwZ3pa9I9Gqy lxw3xJlmBz6LNnuEz4jZF85Lj3anMJNUr4w7oS9REtRkXL5JuLbZsFWiqqQPAaXZ4vo9 UrBOnzC55frKxoWZCdOcMQe9B67Mg38YNr3ul1aZqfrX7rGBZe2pwrE3aSv/KoefJbu8 mRs4v1fUsaCX6OPF93AiE3PkrQqLBUguzm8yguzyK+hny63e7pt+FPiBq3eykbqDyrnT fGbLKcIw2My7sjF2bY9pOSLKwiwUg+ZNgxxAJtIEBXG9g7UWORpbTLuZ5T6Jgz1Fzrqp b0lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=av+uBscM2PY5+/viB0yBeC7bp/XGdO8EPjYNE08WSlw=; b=dvYNaNA0b3gZJanXVwDwOB4QjpGSnqqJ1gYzy60rwiypHm0jeVQsKKm1dS10iYZ1LA 9cQW9h6PuXMLFzOcbCV0Qv3igf4Hf/Jw4LCnWEvIOor4PqA8ZGkyrcsnyFpT6jyc1ZEn rD6ZbHqhBvK0PtJEmNKccmJAwDrI9comNGccUHDhjr1YVVDklScu2kTDxiNqaFnVOvhn cDjsY7WUFkQ3nsP7upFyqPuSVhS7RPJNqd3IKHviipJhh4HnskO42eWf+Ap+p1ztTzgF rOL3ER34r2UP9UoNe6trzL1OolsYJiM7vGhWJTwRTRGW+Jl8j574s7Kv62XWSmKWNvwV th/g== X-Gm-Message-State: AMke39kTbSUgqPrqTx8J8J2Gbf22HC5lx43AxB8w1ZmnEPjy9Rv8avyglc0Ov8uQSUacPDKti2s1hFjqOKx5rg== X-Received: by 10.36.116.71 with SMTP id o68mr9541774itc.60.1488663802993; Sat, 04 Mar 2017 13:43:22 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.134.129 with HTTP; Sat, 4 Mar 2017 13:43:22 -0800 (PST) X-Originating-IP: [69.53.245.200] In-Reply-To: <7ed86250-8f8e-d034-0959-dc46e8973583@FreeBSD.org> References: <201703042020.v24KKD5N078654@pdx.rh.CN85.dnsmgr.net> <7ed86250-8f8e-d034-0959-dc46e8973583@FreeBSD.org> From: Warner Losh Date: Sat, 4 Mar 2017 14:43:22 -0700 X-Google-Sender-Auth: veAQpoOeNybQ9hE7vk7phcXEOKw Message-ID: Subject: Re: svn commit: r314657 - in head/kerberos5: . lib/libgssapi_krb5 lib/libgssapi_ntlm lib/libgssapi_spnego lib/libhdb lib/libkafs5 lib/libkrb5 libexec/hprop libexec/kpasswdd tools/asn1_compile tools/slc To: Bryan Drewery Cc: rgrimes@freebsd.org, Ngie Cooper , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Mar 2017 21:43:23 -0000 On Sat, Mar 4, 2017 at 1:25 PM, Bryan Drewery wrote: > On 3/4/2017 12:20 PM, Rodney W. Grimes wrote: >> -- Start of PGP signed section. >> [ Charset windows-1252 unsupported, converting... ] >>> On 3/4/2017 7:34 AM, Rodney W. Grimes wrote: >>>> What is ${.CURDIR:H:H} ????? Yes that seems to work but now we are obscuring >>>> ../.. into makefile syntax magic, probably not a grand idea. >>> It just trims off the last directory component. This both reduces >>> namecache lookups, lessens the amount of data in a log, and makes >>> debugging a log simpler by not having a crazy path like: >>> /home/bdrewery/big/git/buildserver/sys/modules/usb/template/../../../dev/usb/template/usb_template.c >>> >>> It's far simpler to understand and work with: >>> /home/bdrewery/big/git/buildserver/sys/dev/usb/template/usb_template.c >>> >>> The only downside is it is slightly more obscure in a Makefile, but once >>> you know what :H is then it's not a problem. This is why SRCTOP is even >>> better than this as it is far more clear than even :H and avoids the >>> ../../ problems. >> Lets do one or the other, but not both ${SRCTOP} and :H:H:H. It appears >> that we now have a mix and mashed up some one way others the other. > > That I can agree with. I would prefer to standardize on SRCTOP as :H is > too obscure without learning about make details. :H is insane in 90% of the cases I've seen it used. Let's roll with SRCTOP everywhere we can. That's safer from directory motion anyway... Warner