From owner-freebsd-current Mon Jul 1 13:10:36 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7227137B400 for ; Mon, 1 Jul 2002 13:10:35 -0700 (PDT) Received: from mail.pcnet.com (pcnet1.pcnet.com [204.213.232.3]) by mx1.FreeBSD.org (Postfix) with ESMTP id ABE0A43E0A for ; Mon, 1 Jul 2002 13:10:34 -0700 (PDT) (envelope-from eischen@pcnet1.pcnet.com) Received: from localhost (eischen@localhost) by mail.pcnet.com (8.12.3/8.12.1) with ESMTP id g61KAYL7029158; Mon, 1 Jul 2002 16:10:34 -0400 (EDT) Date: Mon, 1 Jul 2002 16:10:33 -0400 (EDT) From: Daniel Eischen To: Christian Weisgerber Cc: freebsd-current@FreeBSD.ORG Subject: Re: LP64: (int)signal() In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 1 Jul 2002, Christian Weisgerber wrote: > Mike Barcroft wrote: > > > You might want to get rid of the other misuse of `rc' above this and > > just remove the variable. > > The use of an gratuitous int variable rc to capture return values > is rampant throughout this code. In fact, not using it is something > of a violation of the local style, but in the case of signal() I > think it's justifiable because SIG_ERR is so much neater than > changing rc to long and messing around with explicit casts. How about eliminating signal() all together and using sigaction()? -- Dan Eischen To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message