From owner-freebsd-current@FreeBSD.ORG  Tue Apr 17 16:04:18 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 77739106566C;
	Tue, 17 Apr 2012 16:04:18 +0000 (UTC)
	(envelope-from linimon@lonesome.com)
Received: from mail.soaustin.net (pancho.soaustin.net [76.74.250.40])
	by mx1.freebsd.org (Postfix) with ESMTP id 4B0DC8FC0C;
	Tue, 17 Apr 2012 16:04:18 +0000 (UTC)
Received: by mail.soaustin.net (Postfix, from userid 502)
	id 8179A5620B; Tue, 17 Apr 2012 11:04:06 -0500 (CDT)
Date: Tue, 17 Apr 2012 11:04:06 -0500
From: Mark Linimon <linimon@lonesome.com>
To: Dimitry Andric <dim@FreeBSD.org>
Message-ID: <20120417160406.GA11465@lonesome.com>
References: <CADLo838ZKXXS4mVcjG3cnRp=aQdx5Cpas6DLiSsGQO1acqHnwQ@mail.gmail.com>
	<4F52286E.4030608@FreeBSD.org>
	<4F523C1A.4060008@zedat.fu-berlin.de>
	<CAFYLaXPveMM0RCoHSLpG8i2-i6cStWSPrf4FkzZu63Eg--UE+w@mail.gmail.com>
	<4F8BBFF3.50205@FreeBSD.org>
	<CAFYLaXNfYD0E6UbXHO9gBYY0x3eNACQDstubaPZSL_6x4tMzSw@mail.gmail.com>
	<20120416230857.GA26957@mech-cluster241.men.bris.ac.uk>
	<4F8D3565.2020803@FreeBSD.org>
	<20120417093652.GA29091@mech-cluster241.men.bris.ac.uk>
	<4F8D3CB8.5090907@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4F8D3CB8.5090907@FreeBSD.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: Chris Rees <crees@freebsd.org>, Chris <behrnetworks@gmail.com>,
	Current FreeBSD <freebsd-current@freebsd.org>,
	"O. Hartmann" <ohartman@zedat.fu-berlin.de>,
	Doug Barton <dougb@freebsd.org>
Subject: Re: "/sys/conf/kmod.mk", line 111: Malformed conditional
 (${MK_CLANG_IS_CC}
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Apr 2012 16:04:18 -0000

On Tue, Apr 17, 2012 at 11:49:44AM +0200, Dimitry Andric wrote:
> It would hopefully error out.  If you look in /usr/share/mk/bsd.kmod.mk,
> you will see this at the bottom:
> 
>   .if !defined(SYSDIR) || !exists(${SYSDIR}/kern/) || \
>       !exists(${SYSDIR}/conf/kmod.mk)
>   .error Unable to locate the kernel source tree. Set SYSDIR to override.
>   .endif
> 
> So, setting SYSDIR to the correct directory is also a possible solution.

Note that in ports-land we discourage .error in the ports infrastructure
as it can make it impossible to query metadata (e.g. make index,
make -V maintainer, etc.)  So this usage should stay in src.

mcl