From nobody Thu Feb 10 13:36:30 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7308919ACABA; Thu, 10 Feb 2022 13:44:35 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JvdJy2tkPz4cCb; Thu, 10 Feb 2022 13:44:34 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: by mail-ed1-f52.google.com with SMTP id b13so11164261edn.0; Thu, 10 Feb 2022 05:44:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:references:cc:from:subject:in-reply-to :content-transfer-encoding; bh=inyusO9agK9s8yO4AopZPLkYqhan9BWAxt0GutBlyC8=; b=50yn5P4XUid79jlK7wtLij4/K01m+jxwelXARHf3DquRSh8PVYpiG6JzhisvUQWYXY B8fikRJ09O6YnXLV0bPCy8gAjSjij3FXatvzf6pJO1ytM4GqiQAgMSrBzZJzSUYSO99J Wq78KqkgVLKNpeGVgLJQK5Vgu7P5rXUnCkAyq06bIYZ81ycqIHsdN148pWctKZx8ZSgZ x8CANiFEADOBIrrE/3Vbcotb80JxRvB079Zsre4HGestVk0nWAoKUejur41aiaYVu8YH 1N7h3Nc4Lr5iCabdk+49bBB2Bf9rDhw/jnajKWwIgnk/lzPM4zkxaRQTg/Jw0RtVDLVQ QusA== X-Gm-Message-State: AOAM531l8Wj7FkEqKHT/Zsf1FLn3fBfDJn9UD5xDs6qtZ1eM+CVIWoEV 9QnfCuYUcTLvPK25KxUMfHBFKyQG8l/5fg== X-Google-Smtp-Source: ABdhPJwjOxCrq+miLysDc1Y2ONHEjPZgCvEJvXr1XHd3Jyj1TH8R7Ore/z5qDu9+XBAAS9RC2h6+9Q== X-Received: by 2002:a17:907:9812:: with SMTP id ji18mr6580930ejc.200.1644500192239; Thu, 10 Feb 2022 05:36:32 -0800 (PST) Received: from [192.168.0.104] (ip5f5bd4cf.dynamic.kabel-deutschland.de. [95.91.212.207]) by smtp.gmail.com with ESMTPSA id c25sm9568623edu.103.2022.02.10.05.36.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Feb 2022 05:36:31 -0800 (PST) Message-ID: <50175512-5528-f93f-33cf-90f92f2e41b1@FreeBSD.org> Date: Thu, 10 Feb 2022 14:36:30 +0100 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Content-Language: en-US To: Chuck Silvers , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202202100248.21A2mMWw070398@gitrepo.freebsd.org> Cc: dtrace@freebsd.org From: Mateusz Piotrowski <0mp@FreeBSD.org> Subject: Re: git: f339a3ef6369 - main - dtrace: remove unnecessary fflush() In-Reply-To: <202202100248.21A2mMWw070398@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4JvdJy2tkPz4cCb X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of mpp302@gmail.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=mpp302@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.208.52:from]; MLMMJ_DEST(0.00)[dev-commits-src-all,dev-commits-src-main,dtrace]; FORGED_SENDER(0.30)[0mp@FreeBSD.org,mpp302@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.208.52:from]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[0mp@FreeBSD.org,mpp302@gmail.com]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[95.91.212.207:received] X-ThisMailContainsUnwantedMimeParts: N Hello everyone, On 10/02/2022 03:48, Chuck Silvers wrote: > The branch main has been updated by chs: > > URL: https://cgit.FreeBSD.org/src/commit/?id=f339a3ef6369b368f3a2455792a7a3a4c28f92c4 > > commit f339a3ef6369b368f3a2455792a7a3a4c28f92c4 > Author: Chuck Silvers > AuthorDate: 2022-02-10 01:09:26 +0000 > Commit: Chuck Silvers > CommitDate: 2022-02-10 01:09:26 +0000 > > dtrace: remove unnecessary fflush() > > This call was added back in the early days of dtrace porting and > no one knows why anymore. The extra flushing causes lots of > unnecessary CPU overhead when a script produces lots of output, > as well as easily losing output because the command can't keep up. Did you have some specific way to measure the CPU overhead of DTrace here? I'm interested in this kind of performance measurements and I wonder if anything more sophisticated than observing top(1) was used to test this change. Thanks! Best, Mateusz Piotrowski