Date: Thu, 10 Feb 2022 14:36:30 +0100 From: Mateusz Piotrowski <0mp@FreeBSD.org> To: Chuck Silvers <chs@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: dtrace@freebsd.org Subject: Re: git: f339a3ef6369 - main - dtrace: remove unnecessary fflush() Message-ID: <50175512-5528-f93f-33cf-90f92f2e41b1@FreeBSD.org> In-Reply-To: <202202100248.21A2mMWw070398@gitrepo.freebsd.org> References: <202202100248.21A2mMWw070398@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello everyone, On 10/02/2022 03:48, Chuck Silvers wrote: > The branch main has been updated by chs: > > URL: https://cgit.FreeBSD.org/src/commit/?id=f339a3ef6369b368f3a2455792a7a3a4c28f92c4 > > commit f339a3ef6369b368f3a2455792a7a3a4c28f92c4 > Author: Chuck Silvers <chs@FreeBSD.org> > AuthorDate: 2022-02-10 01:09:26 +0000 > Commit: Chuck Silvers <chs@FreeBSD.org> > CommitDate: 2022-02-10 01:09:26 +0000 > > dtrace: remove unnecessary fflush() > > This call was added back in the early days of dtrace porting and > no one knows why anymore. The extra flushing causes lots of > unnecessary CPU overhead when a script produces lots of output, > as well as easily losing output because the command can't keep up. Did you have some specific way to measure the CPU overhead of DTrace here? I'm interested in this kind of performance measurements and I wonder if anything more sophisticated than observing top(1) was used to test this change. Thanks! Best, Mateusz Piotrowski
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50175512-5528-f93f-33cf-90f92f2e41b1>