From owner-cvs-src-old@FreeBSD.ORG Thu Mar 31 14:00:15 2011 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3C6AF1065678 for ; Thu, 31 Mar 2011 14:00:15 +0000 (UTC) (envelope-from fabient@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B06AF8FC0A for ; Thu, 31 Mar 2011 14:00:05 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id p2VE05ZQ082538 for ; Thu, 31 Mar 2011 14:00:05 GMT (envelope-from fabient@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id p2VE05dn082537 for cvs-src-old@freebsd.org; Thu, 31 Mar 2011 14:00:05 GMT (envelope-from fabient@repoman.freebsd.org) Message-Id: <201103311400.p2VE05dn082537@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to fabient@repoman.freebsd.org using -f From: Fabien Thomas Date: Thu, 31 Mar 2011 13:59:47 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern sched_4bsd.c sched_ule.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2011 14:00:15 -0000 fabient 2011-03-31 13:59:47 UTC FreeBSD src repository Modified files: sys/kern sched_4bsd.c sched_ule.c Log: SVN rev 220198 on 2011-03-31 13:59:47Z by fabient Clearing the flag when preempting will let the preempted thread run too much time. This can finish in a scheduler deadlock with ping-pong between two threads. One sample of this is: - device lapic (to have a preemption point on critical_exit()) - options DEVICE_POLLING with HZ>1499 (to have lapic freq = hardclock freq) - running a cpu intensive task (that does not enter the kernel) - only one CPU on SMP or no SMP. As requested by jhb@ 4BSD have received the same type of fix instead of propagating the flag to the new thread. Reviewed by: jhb, jeff MFC after: 1 month Revision Changes Path 1.150 +2 -6 src/sys/kern/sched_4bsd.c 1.291 +2 -1 src/sys/kern/sched_ule.c