From owner-cvs-src@FreeBSD.ORG  Wed Jan 31 15:56:50 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 0252D16A402;
	Wed, 31 Jan 2007 15:56:50 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.freebsd.org (Postfix) with ESMTP id B5ABB13C47E;
	Wed, 31 Jan 2007 15:56:49 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11])
	(authenticated bits=0)
	by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id l0VFuheb085216;
	Wed, 31 Jan 2007 08:56:48 -0700 (MST)
	(envelope-from scottl@samsco.org)
Message-ID: <45C0BC2F.9060303@samsco.org>
Date: Wed, 31 Jan 2007 08:56:31 -0700
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US;
	rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1
MIME-Version: 1.0
To: Andrew Gallatin <gallatin@FreeBSD.org>
References: <200701311547.l0VFliLC039432@repoman.freebsd.org>
In-Reply-To: <200701311547.l0VFliLC039432@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]);
	Wed, 31 Jan 2007 08:56:48 -0700 (MST)
X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed 
	version=3.1.1
X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/mxge if_mxge.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Jan 2007 15:56:50 -0000

Andrew Gallatin wrote:
> gallatin    2007-01-31 15:47:44 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/mxge         if_mxge.c 
>   Log:
>   destroy busdma maps even if they are NULL, so as to avoid leaking
>   busdma tags.
>   
>   Revision  Changes    Path
>   1.19      +16 -18    src/sys/dev/mxge/if_mxge.c

Yeah, I can't stress enough that busdma maps are opaque handles and
should always be handled like they are valid.  It's only an
implementation detail that they are often NULL on i386 and amd64.

Scott