From owner-freebsd-bugs Fri Oct 23 21:50:07 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id VAA14218 for freebsd-bugs-outgoing; Fri, 23 Oct 1998 21:50:07 -0700 (PDT) (envelope-from owner-freebsd-bugs@FreeBSD.ORG) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA14202 for ; Fri, 23 Oct 1998 21:50:04 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id VAA11503; Fri, 23 Oct 1998 21:50:00 -0700 (PDT) Received: from gatekeeper.tsc.tdk.com (gatekeeper.tsc.tdk.com [207.113.159.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA13450 for ; Fri, 23 Oct 1998 21:40:16 -0700 (PDT) (envelope-from gdonl@tsc.tdk.com) Received: from sunrise.gv.tsc.tdk.com (root@sunrise.gv.tsc.tdk.com [192.168.241.191]) by gatekeeper.tsc.tdk.com (8.8.8/8.8.8) with ESMTP id VAA22897 for ; Fri, 23 Oct 1998 21:39:45 -0700 (PDT) (envelope-from gdonl@tsc.tdk.com) Received: from w3.gv.tsc.tdk.com (gdonl@w3.gv.tsc.tdk.com [192.168.240.195]) by sunrise.gv.tsc.tdk.com (8.8.5/8.8.5) with ESMTP id VAA10612 for ; Fri, 23 Oct 1998 21:39:43 -0700 (PDT) Received: (from gdonl@localhost) by w3.gv.tsc.tdk.com (8.8.8/8.8.5) id VAA14919; Fri, 23 Oct 1998 21:39:22 -0700 (PDT) Message-Id: <199810240439.VAA14919@w3.gv.tsc.tdk.com> Date: Fri, 23 Oct 1998 21:39:22 -0700 (PDT) From: Don Lewis Reply-To: gdonl@tsc.tdk.com To: FreeBSD-gnats-submit@FreeBSD.ORG X-Send-Pr-Version: 3.2 Subject: bin/8427: [PATCH] fsdb buglet Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org >Number: 8427 >Category: bin >Synopsis: [PATCH] fsdb buglet >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Oct 23 21:50:00 PDT 1998 >Last-Modified: >Originator: Don Lewis >Organization: TDK Semiconductor >Release: FreeBSD 3.0-CURRENT >Environment: FreeBSD 2.1 through 3.0 >Description: There is a minor bug in the CMDFUNCSTART() routine in fsdb. The code accidentally happens to compile and run correctly because it finds an unrelated variable declaration in fsck.h that just happens to have a type that makes the code work. This bug needs to be fixed before Kirk McKusick's softupdates aware fsck can be integrated. >How-To-Repeat: >Fix: --- fsdb/fsdb.c.orig Mon Jun 15 00:12:19 1998 +++ fsdb/fsdb.c Fri Oct 23 18:12:24 1998 @@ -617,7 +617,7 @@ return 1; type = curinode->di_mode & IFMT; for (tp = typenamemap; - tp < &typenamemap[sizeof(typemap)/sizeof(*typemap)]; + tp < &typenamemap[sizeof(typenamemap)/sizeof(*typenamemap)]; tp++) { if (!strcmp(argv[1], tp->typename)) { printf("setting type to %s\n", tp->typename); @@ -625,7 +625,7 @@ break; } } - if (tp == &typenamemap[sizeof(typemap)/sizeof(*typemap)]) { + if (tp == &typenamemap[sizeof(typenamemap)/sizeof(*typenamemap)]) { warnx("type `%s' not known", argv[1]); warnx("try one of `file', `dir', `socket', `fifo'"); return 1; >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message