Date: Wed, 13 Dec 2023 07:37:39 -0500 From: Adam Weinberger <adamw@adamw.org> To: Mathieu Arnold <mat@freebsd.org> Cc: Gerald Pfeifer <gerald@pfeifer.com>, Larry Rosenman <ler@freebsd.org>, Ashish SHUKLA <ashish@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 8d096cbc7af5 - main - sysutils/lsof: add a build depends on bash for the timebeing. Message-ID: <CAP7rwcjXhUGT_MiSi6gseMnLGXmn39vUmyA9r0GGrtLFaz7_cQ@mail.gmail.com> In-Reply-To: <magfc3arlgw6cnqa4bgl73ho344bvrnthionsr4gaig6kab5wy@mo7mzrlc4blx> References: <202312050108.3B518qwD065426@gitrepo.freebsd.org> <653e5bc3811b06d371517936f02cf0c2@FreeBSD.org> <1e93ed1a910819a38a332a580b4746d0@FreeBSD.org> <526e9cf0-55cf-afac-b8b5-5005e63cc6ae@pfeifer.com> <CAP7rwcieVLpb9Z4ENHBxkRb88XkToj7TWZccKhPq=q-L_JWyyw@mail.gmail.com> <magfc3arlgw6cnqa4bgl73ho344bvrnthionsr4gaig6kab5wy@mo7mzrlc4blx>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000b20ca5060c636fbf
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
On Wed, Dec 13, 2023 at 7:20=E2=80=AFAM Mathieu Arnold <mat@freebsd.org> wr=
ote:
> On Wed, Dec 13, 2023 at 06:32:44AM -0500, Adam Weinberger wrote:
> > On Wed, Dec 13, 2023 at 12:26=E2=80=AFAM Gerald Pfeifer <gerald@pfeifer=
.com>
> wrote:
> >
> > > On Mon, 4 Dec 2023, Larry Rosenman wrote:
> > > >>> +BUILD_DEPENDS=3D /usr/local/bin/bash:shells/bash
> > > >> s,/usr/local,${LOCALBASE},
> > > > I'm out of practice :(
> > >
> > > No worries, just note we have tools to support us.
> > >
> > > I gave this a try and got the following from portlint:
> > >
> > > % portlint -C
> > > WARN: Makefile: possible use of absolute pathname
> > > "/usr/local/bin/bash:...".
> > >
> >
> > Also just FTR, BUILD/RUN_DEPENDS works without absolute pathnames. This
> > would work fine too (and is the more common invocation):
> > BUILD_DEPENDS=3D bash:shells/bash
>
> They are semantically different.
>
> bash:shells/bash means I need a bash executable, like, for running shell
> scripts.
>
> LOCAL/bin/bash:shells/bash means I need the LOCAL/bin/bash file, it may
> not be for execution. It is more usually used for a header, I do not see
> why one would need bash but not for running it.
>
> --
> Mathieu Arnold
>
That's a good point, and my message definitely glossed over that.
foo:net/foo =3D=3D ${LOCALBASE}/bin/foo:net/foo (as long as foo is n=
ot
in base)
${LOCALBASE}/share/foo/foo.h:net/foo for non-executables
# Adam
--=20
Adam Weinberger
adamw@adamw.org
https://www.adamw.org
--000000000000b20ca5060c636fbf
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:arial,sans-serif"><br></div></div><br><div class=3D"gmail_quote"><=
div dir=3D"ltr" class=3D"gmail_attr">On Wed, Dec 13, 2023 at 7:20=E2=80=AFA=
M Mathieu Arnold <<a href=3D"mailto:mat@freebsd.org">mat@freebsd.org</a>=
> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px =
0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On W=
ed, Dec 13, 2023 at 06:32:44AM -0500, Adam Weinberger wrote:<br>
> On Wed, Dec 13, 2023 at 12:26=E2=80=AFAM Gerald Pfeifer <<a href=3D=
"mailto:gerald@pfeifer.com" target=3D"_blank">gerald@pfeifer.com</a>> wr=
ote:<br>
> <br>
> > On Mon, 4 Dec 2023, Larry Rosenman wrote:<br>
> > >>> +BUILD_DEPENDS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0/usr/local/bin/bash:shells/bash<br>
> > >> s,/usr/local,${LOCALBASE},<br>
> > > I'm out of practice :(<br>
> ><br>
> > No worries, just note we have tools to support us.<br>
> ><br>
> > I gave this a try and got the following from portlint:<br>
> ><br>
> >=C2=A0 =C2=A0% portlint -C<br>
> >=C2=A0 =C2=A0WARN: Makefile: possible use of absolute pathname<br>
> > "/usr/local/bin/bash:...".<br>
> ><br>
> <br>
> Also just FTR, BUILD/RUN_DEPENDS works without absolute pathnames. Thi=
s<br>
> would work fine too (and is the more common invocation):<br>
> BUILD_DEPENDS=3D=C2=A0 bash:shells/bash<br>
<br>
They are semantically different.<br>
<br>
bash:shells/bash means I need a bash executable, like, for running shell<br=
>
scripts.<br>
<br>
LOCAL/bin/bash:shells/bash means I need the LOCAL/bin/bash file, it may<br>
not be for execution. It is more usually used for a header, I do not see<br=
>
why one would need bash but not for running it.<br>
<br>
-- <br>
Mathieu Arnold<br>
</blockquote></div><div><br></div><div><div style=3D"font-family:arial,sans=
-serif" class=3D"gmail_default">That's a good point, and my message def=
initely glossed over that.</div><div style=3D"font-family:arial,sans-serif"=
class=3D"gmail_default"><br></div><div style=3D"font-family:arial,sans-ser=
if" class=3D"gmail_default">=C2=A0 foo:net/foo=C2=A0 =3D=3D=C2=A0 ${LOCALBA=
SE}/bin/foo:net/foo=C2=A0=C2=A0=C2=A0 (as long as foo is not in base)</div>=
<div style=3D"font-family:arial,sans-serif" class=3D"gmail_default"><br></d=
iv><div style=3D"font-family:arial,sans-serif" class=3D"gmail_default">=C2=
=A0 ${LOCALBASE}/share/foo/foo.h:net/foo=C2=A0 for non-executables<br></div=
></div><div><br></div><div><div style=3D"font-family:arial,sans-serif" clas=
s=3D"gmail_default"># Adam<br></div><br></div><br><span class=3D"gmail_sign=
ature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><div=
dir=3D"ltr"><div><div dir=3D"ltr"><div>Adam Weinberger</div><div><a href=
=3D"mailto:adamw@adamw.org" target=3D"_blank">adamw@adamw.org</a></div><div=
><a href=3D"https://www.adamw.org" target=3D"_blank">https://www.adamw.org<=
/a></div></div></div></div></div></div>
--000000000000b20ca5060c636fbf--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwcjXhUGT_MiSi6gseMnLGXmn39vUmyA9r0GGrtLFaz7_cQ>