From owner-freebsd-hackers@freebsd.org Sat Feb 24 18:35:55 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 552A5F00BFA for ; Sat, 24 Feb 2018 18:35:55 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yb0-x236.google.com (mail-yb0-x236.google.com [IPv6:2607:f8b0:4002:c09::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E7359709B9 for ; Sat, 24 Feb 2018 18:35:54 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yb0-x236.google.com with SMTP id i13-v6so4027059ybl.9 for ; Sat, 24 Feb 2018 10:35:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=uY7mq37ngYgaBwjpjHzIRQqjZoOUrRCm+t8ntrrh0ok=; b=qU5QqdQrV1lNzAkwtDm1/7s5QzuSWkmXWrhdQqg6XAuM3TOP4IRewg3DoZvyNdXmYY Q2eBxujiiCfsaRslP/xB40ull6XaTGAnkNG6J1owyAspt+cBgGcj+VVr3sF2x05c3nF4 0GKC2LUPqcROo38LMHKjwCK/C/gAXrYJs9WGs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=uY7mq37ngYgaBwjpjHzIRQqjZoOUrRCm+t8ntrrh0ok=; b=RY5psBP2k0VygxYbEQDK14IKdF1cXOm4NLAL4FuQLAZd+rsiX1tdA2oiaoASr6kPGl m4/T4nulBw/j7EeVXcWRB4Y9ZSmBYyfAFuVFa0q8R0Cs1rg3ngGGGVykeNU+3Qpb7BpP XKeqWpm+DGVpxzWvUaIAPrGaoHWIuBonqKjPOzWd/DvG51PFW5luyhDvgSeO7d/udT+M GMYuFj63M/UTEKTOnxXLEYrpX0QWbwBxbTfFcgUIk5vjxMJ2myQJZsDg5W/L9dSZBJS4 Z1c+v18WP0XSyOJgkenSk17wzK+HmIat83eN9K5hNGk6SWCLNSxTy/DlTTz+ATBzaYOK h7Kg== X-Gm-Message-State: APf1xPDMUO997LK9SQYAaRX4Y93F2xBAoobm/fyHEJ85GnC+C5Z9u1Sm rW2dvLs2552CW3A6MYrT96/LJAmhDXi8jnUTpoWx0g== X-Google-Smtp-Source: AG47ELvbbnVZG/avZmCrSCt4xp79Z+G+jhZckVOYC8tcwTE+7BNYRxuryQey1ovNkyT7Z/RczvysHG6mUUqD7wvcZ4c= X-Received: by 2002:a25:6006:: with SMTP id u6-v6mr3767999ybb.460.1519497354117; Sat, 24 Feb 2018 10:35:54 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a25:dfcb:0:0:0:0:0 with HTTP; Sat, 24 Feb 2018 10:35:23 -0800 (PST) In-Reply-To: References: <20180221032247.GA81670@ns.kevlo.org> <20180221104400.GU94212@kib.kiev.ua> <23181.46427.671514.319710@khavrinen.csail.mit.edu> <20180221185920.GA94212@kib.kiev.ua> <23181.50488.186767.579361@khavrinen.csail.mit.edu> <20180221201002.GC94212@kib.kiev.ua> <23181.54825.511195.393054@khavrinen.csail.mit.edu> <20180222212746.GB58772@stack.nl> From: Eitan Adler Date: Sat, 24 Feb 2018 10:35:23 -0800 Message-ID: Subject: Re: Marking select(2) as restrict To: Jilles Tjoelker , FreeBSD Hackers Cc: Garrett Wollman , FreeBSD Standards Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Feb 2018 18:35:55 -0000 After this entire thread here is the summary. If I've misrepresented you here please let me know. Stefan Blachmann - concerned about possible breakages. kevlo - no comment julian@freebsd.org - no comment imp@ - concerned about lack of warnings; objected to original fix of devd Gary Jennejohn - pselect already has the modifiers. no comment. kib@ - no benefit; concerned fallout could be hard to observe Garrett Wollman - positive due to following the standard Tijil - glibc already uses it. limited fallout expected Eric van Gyzen - would prefer "make check" in the exp-run as well cem@ - concerned about warnings My thoughts: The main concern is that things /might/ break in undetectable was. However most other operating already have these marked as restrict, and no concrete brokenness for FreeBSD have been shown. I'd rather aim for correctness than avoiding speculative fallout. This is a tradeoff, but one I think is good here. Final action: I am planning on committing a modified version of the original patch after an exp-run. I will ask for port tests to be run if possible. This will be posted to phab for review for technical correctness. This will not be merged to stable/11. In the event of observable fallout it can be reverted. On 22 February 2018 at 23:26, Eitan Adler wrote: > On 22 February 2018 at 13:27, Jilles Tjoelker wrote: >> On Wed, Feb 21, 2018 at 03:27:21PM -0500, Garrett Wollman wrote: >>> < said: > ... > > FWIW > > glibc: already done - > https://github.com/bminor/glibc/blob/master/misc/sys/select.h#L101 > openbsd: already done > https://github.com/openbsd/src/blob/master/sys/sys/select.h#L128 > dragonflyBSD: alredy done: > https://github.com/dragonflybsd/dragonflybsd/blob/master/sys/sys/select.h#L50 > netbsd: already done: > https://github.com/NetBSD/src/blob/trunk/sys/sys/select.h#L69 > > The patch that started this thread was incomplete, as it didn't > include the timeval but I'll have an updated version in a phab soon. > > -- > Eitan Adler -- Eitan Adler