From owner-svn-src-all@FreeBSD.ORG Mon Apr 13 05:08:13 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7D5861065670 for ; Mon, 13 Apr 2009 05:08:13 +0000 (UTC) (envelope-from silby@silby.com) Received: from relay03.pair.com (relay03.pair.com [209.68.5.17]) by mx1.freebsd.org (Postfix) with SMTP id 9E50C8FC16 for ; Mon, 13 Apr 2009 05:08:12 +0000 (UTC) (envelope-from silby@silby.com) Received: (qmail 72685 invoked from network); 13 Apr 2009 05:08:11 -0000 Received: from 209.68.2.70 (HELO localhost) (209.68.2.70) by relay03.pair.com with SMTP; 13 Apr 2009 05:08:11 -0000 X-pair-Authenticated: 209.68.2.70 Date: Mon, 13 Apr 2009 00:08:10 -0500 (CDT) From: Mike Silbersack To: Jack F Vogel In-Reply-To: <200904100005.n3A05lIu025175@svn.freebsd.org> Message-ID: References: <200904100005.n3A05lIu025175@svn.freebsd.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r190872 - head/sys/dev/e1000 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Apr 2009 05:08:13 -0000 Jack, either this or some other recent change to the em driver caused it to stop working correctly on the e1000 virtual device inside VMware ESX. Unfortunately, I have not updated my 8.x VMs recently, so I don't know when this broke. I got the message about an invalid MAC address. I modified em_is_valid_ether_addr to always return True, but it looks like the effect of that was to cause the driver to load, but give the NIC a MAC of 00:00:00:00:00:00. However, if I manually set a MAC after that, the virtual NIC IS functional. So I think the sole problem may just be that the code which reads the MAC is incompatible with the ESX emulation. Do you want me to try a kernel from immediately before this change to confirm that this was the cause of the problem? Mike "Silby" Silbersack On Fri, 10 Apr 2009, Jack F Vogel wrote: > Author: jfv > Date: Fri Apr 10 00:05:46 2009 > New Revision: 190872 > URL: http://svn.freebsd.org/changeset/base/190872 > > Log: > This delta syncs the em and igb drivers with Intel, > adds header split and SCTP support into the igb driver. > Various small improvements and fixes. >