From owner-svn-src-all@freebsd.org Mon Jan 11 15:03:35 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3937BA6A03F; Mon, 11 Jan 2016 15:03:35 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from mr11p00im-asmtp003.me.com (mr11p00im-asmtp003.me.com [17.110.69.254]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 245AA1BBF; Mon, 11 Jan 2016 15:03:35 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from [192.168.1.4] (c-24-6-178-251.hsd1.ca.comcast.net [24.6.178.251]) by mr11p00im-asmtp003.me.com (Oracle Communications Messaging Server 7.0.5.36.0 64bit (built Sep 8 2015)) with ESMTPSA id <0O0S00I2UN5XWW20@mr11p00im-asmtp003.me.com>; Mon, 11 Jan 2016 15:03:34 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-01-11_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1011 suspectscore=18 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1510270003 definitions=main-1601110267 User-Agent: Microsoft-MacOutlook/0.0.0.151217 Date: Mon, 11 Jan 2016 07:03:32 -0800 Subject: Re: svn commit: r292788 - in head/sys: geom/part sys From: Ravi Pokala Sender: "Pokala, Ravi" To: "Andrey V. Elsukov" , Ravi Pokala , Allan Jude , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-id: <12E970B9-E993-4071-B334-021AB155D0B4@panasas.com> Thread-topic: svn commit: r292788 - in head/sys: geom/part sys References: <201512271812.tBRICD3A044563@repo.freebsd.org> <1F9E33A5-A9D7-44A9-9519-2A1593BFF990@panasas.com> <56936975.9000202@yandex.ru> In-reply-to: <56936975.9000202@yandex.ru> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2016 15:03:35 -0000 -----Original Message----- From: on behalf of "Andrey V. Elsukov" <= bu7cher@yandex.ru> Date: 2016-01-11, Monday at 00:36 To: Ravi Pokala , Allan Jude , , , Subject: Re: svn commit: r292788 - in head/sys: geom/part sys >On 11.01.16 07:54, Ravi Pokala wrote: >> In that review, there was discussion about the sorting of aliases in >(enum g_part_alias). It was originally thought that the aliases needed >to be sorted, due to binary searching in g_part_alias_name(). It turned >out that g_part_alias_name() did a linear search, so the list didn't >strictly need to be sorted. But, there was talk of potentially switching >to a binary search later, so Allan went with the sorted version. > >Hi, > >no, my note was relate to the following possible problem: >you have some stable/10 and some geom_part_panasas module installed from >the ports in the /boot/modules. When you rebuild the kernel after >merging r292788 your module will use old values of g_part_alias and thus >it will get not the same aliases. You will need rebuild your module to >fix this. Right, I explained your concerns later down in the email. However, I don't = think they're applicable, because it doesn=E2=80=99t look like anything is actuall= y using the enum outside of GEOM_PART driver. Thanks, Ravi (rpokala@)