From owner-svn-src-head@freebsd.org Mon Feb 27 04:07:30 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7FBA8CEF56A; Mon, 27 Feb 2017 04:07:30 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 34778197; Mon, 27 Feb 2017 04:07:29 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id iCamcSZdbsa1kiCancFspY; Sun, 26 Feb 2017 21:07:22 -0700 X-Authority-Analysis: v=2.2 cv=W+NIbVek c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=n2v9WMKugxEA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=bo0pdqHELOON81cyJx8A:9 a=CjuIK1q_8ugA:10 a=9WeMLp5Z2dYA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 3BF9F328; Sun, 26 Feb 2017 20:07:20 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id v1R47JXY004778; Sun, 26 Feb 2017 20:07:19 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201702270407.v1R47JXY004778@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Warner Losh cc: Cy Schubert , Pedro Giffuni , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r314322 - head/lib/librss In-Reply-To: Message from Warner Losh of "Sun, 26 Feb 2017 20:17:28 -0700." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 26 Feb 2017 20:07:19 -0800 X-CMAE-Envelope: MS4wfByNn89Xt3HB0x7RgOzUPKQpncO5xKxSs0DRPpZ6KEx24DFNKqM9Efa6poYmYkFc79TJt9g5omZWrp6GzQMZQ9IpVrPMYNQ4QBSDsbX6GGGCGIh8GqOk D5wPBcVBS3hzdZszHoeUgbNb/k95Frxf8xqgpou3I2M6/pTR9ZQxblOhkSwYy/RsnQwcpV7zL+qOPryv0J+KLO/F+XyocXpryRs1p1S/pCJMe+b9ejBqb8Yg D0pFC95t7GQtSHA0C/Ks5cWcMB0UC0E6E9Jbf0axgmXELswMNdIxpqqusbzhjb6ov/2VddecaXpLlzCKA+JY5w== X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2017 04:07:30 -0000 In message , Warner Losh writes: > > Then why even test for RC being NULL? > > So rc->rss_bucket_map doesn't dereference a null pointer and core dump maybe? Yes. I overlooked that. :( -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.