From nobody Fri Jul 31 11:23:57 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hBNxV1ZsHz6mYrR for ; Fri, 31 Jul 2026 11:23:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hBNxT5X1Mz47Zd for ; Fri, 31 Jul 2026 11:23:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785497037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BhplqQDWjgOGqnanDJMvssh/cm4eXcTGa+V4tXR+mC0=; b=HV0M6raiwCXykmxEEUzR2yPRqiIW6mg9ty2k8V+ExcnhuhTVKkxezKCnUnAM4PORGGAtj7 RGQRjgmpErwLFjBu4XrrOZNM3rem/iZqHTr5GtF8oKo/JNOqpzR50sse5B3KwvJ4otnDf1 7b2JceDc54o1Q2ZS2zohWvLF3dMU5Wz+/EkHFQH86x/GjGNV3by6TH0AaXcgjCGAfuqk2N 8HPe9Ar0VRKCfsjsIy29NXneuE7ERYlZoZtLAqJ0wvvKlytXAWmdvAuw77SjhZotr/NOWS 2eDX8U+x8BhIzWEvXAKus/0aEm5LPCjDK6bd7M0B4jE4Bj69I0l32yt8h1FDtA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785497037; a=rsa-sha256; cv=none; b=Z/atQs7svALJJ5Eshhsdp5XQAdFxxhWND/wvDtToowwgbq5jBsLto5NwgJlM5BQxDp/DSJ abN83VFVOlkqvg6XofxCIsWs72DlqBtA7ceMGDUTxgRjJE2pKXpMPhcVaFQ41boNAyKXG8 lWPsT/oJ8lXqMDATBGMLKiK855zBaoLH0LktwBTnn+yMfeOV/V4xYzBwb3lxhRvsLnQ7NI m8w0F4LX4bdIORMQIzaYv8ik+KCfBgA+lFw68NEOLUJf2TS9BheeQxu/EzTI5ZrGFAEKQ0 HVUbVcf1KqXMDd4gDZwW9mwrBqsVuZmwWKogx7TNYRAd11krYv3ftjQBZJOCAg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785497037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BhplqQDWjgOGqnanDJMvssh/cm4eXcTGa+V4tXR+mC0=; b=e4C/kNBPkzraPGKiksrxboRHRI0xReft0gGnR8FUfN5IEbH76EVteFPhdWFB9nEzv8ruuX Pw+C/hzCucBI5pAUB3j8HcadpFLj/FiLkk08DzAdscd3HdNzDbqOSoHLm3kwF/FaqqMD+S 7a6720j4+TcbnNFNXhMp/9fCEoCbZP9wBbtlwi0S1f7lgJ9X0yyAGBnN+k9uHJqbYlnPzx 7VfqzYNoscJJ1eBXAaU5eev+jfhrUpCPSn6nHv5vYm6NjuWDcu5RmfdhKZcGexcSFhXMU+ Q2V9LVmlzBOUWeCRdHzoVcZDv4sViTIgJbs3rxJF2j3ITPej+yGiM7wIPMUEAg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hBNxT473jzxq1 for ; Fri, 31 Jul 2026 11:23:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3e113 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 31 Jul 2026 11:23:57 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 8fa2a7503468 - main - ixgbe: fix unaligned access in ixgbe_update_flash_X550() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8fa2a7503468abb5f863729c4e244d738239503d Auto-Submitted: auto-generated Date: Fri, 31 Jul 2026 11:23:57 +0000 Message-Id: <6a6c85cd.3e113.16f87be8@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=8fa2a7503468abb5f863729c4e244d738239503d commit 8fa2a7503468abb5f863729c4e244d738239503d Author: Kevin Bowling AuthorDate: 2026-07-28 11:09:39 +0000 Commit: Kevin Bowling CommitDate: 2026-07-31 11:23:21 +0000 ixgbe: fix unaligned access in ixgbe_update_flash_X550() ixgbe_host_interface_command() treats its buffer as a u32 array. The local union contained only byte-sized fields, giving it one-byte stack alignment and allowing unaligned accesses on strict-align systems. Add a u32 member to the union to provide the required alignment and pass that member to ixgbe_host_interface_command(). No functional change is expected on x86. Obtained from: Intel ix 3.4.39 MFC after: 1 week --- sys/dev/ixgbe/ixgbe_type.h | 1 + sys/dev/ixgbe/ixgbe_x550.c | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/ixgbe/ixgbe_type.h b/sys/dev/ixgbe/ixgbe_type.h index 4e242b7189cb..80f8effca6d5 100644 --- a/sys/dev/ixgbe/ixgbe_type.h +++ b/sys/dev/ixgbe/ixgbe_type.h @@ -3273,6 +3273,7 @@ struct ixgbe_hic_hdr2_rsp { }; union ixgbe_hic_hdr2 { + u32 buf[1]; struct ixgbe_hic_hdr2_req req; struct ixgbe_hic_hdr2_rsp rsp; }; diff --git a/sys/dev/ixgbe/ixgbe_x550.c b/sys/dev/ixgbe/ixgbe_x550.c index 7f07190f832c..f6ce0d10b9e2 100644 --- a/sys/dev/ixgbe/ixgbe_x550.c +++ b/sys/dev/ixgbe/ixgbe_x550.c @@ -3557,8 +3557,7 @@ s32 ixgbe_update_flash_X550(struct ixgbe_hw *hw) buffer.req.buf_lenl = FW_SHADOW_RAM_DUMP_LEN; buffer.req.checksum = FW_DEFAULT_CHECKSUM; - status = ixgbe_host_interface_command(hw, (u32 *)&buffer, - sizeof(buffer), + status = ixgbe_host_interface_command(hw, buffer.buf, sizeof(buffer), IXGBE_HI_COMMAND_TIMEOUT, false); return status;