From owner-svn-src-all@freebsd.org Sat Mar 17 01:57:14 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1F0E5F600AD; Sat, 17 Mar 2018 01:57:14 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from mx1.scaleengine.net (mx1.scaleengine.net [209.51.186.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B7C7E7FA1C; Sat, 17 Mar 2018 01:57:13 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from [10.254.254.65] (senat1-01.HML3.ScaleEngine.net [209.51.186.5]) (Authenticated sender: allanjude.freebsd@scaleengine.com) by mx1.scaleengine.net (Postfix) with ESMTPSA id 85656147C0; Sat, 17 Mar 2018 01:57:07 +0000 (UTC) Subject: Re: svn commit: r331064 - head/sbin/ifconfig To: Kirill Ponomarev Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201803161656.w2GGuvOv016658@repo.freebsd.org> <90FB9B8F-DF2E-49E5-BD86-197CE3B312A4@sigsegv.be> From: Allan Jude Message-ID: <645c3f81-6b43-2426-bfc9-ade4bfdb382a@freebsd.org> Date: Fri, 16 Mar 2018 21:56:59 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <90FB9B8F-DF2E-49E5-BD86-197CE3B312A4@sigsegv.be> Content-Type: text/plain; charset=utf-8 Content-Language: en-CA Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Mar 2018 01:57:14 -0000 On 2018-03-16 19:54, Kristof Provost wrote: > On 16 Mar 2018, at 17:56, Kirill Ponomarev wrote: >> Author: krion (ports committer) >> Date: Fri Mar 16 16:56:56 2018 >> New Revision: 331064 >> URL: https://svnweb.freebsd.org/changeset/base/331064 >> >> Log: >>   Extend SSID maximum string length to 32 chars to support longer SSID >>   names. >> >>   Approved by:    adrian >>   Differential Revision:    https://reviews.freebsd.org/D14710 >> >> Modified: >>   head/sbin/ifconfig/ifieee80211.c >> >> Modified: head/sbin/ifconfig/ifieee80211.c >> ============================================================================== >> >> --- head/sbin/ifconfig/ifieee80211.c    Fri Mar 16 16:06:25 2018    >> (r331063) >> +++ head/sbin/ifconfig/ifieee80211.c    Fri Mar 16 16:56:56 2018    >> (r331064) >> @@ -3503,7 +3503,7 @@ list_scan(int s) >> >>      getchaninfo(s); >> >> -    ssidmax = verbose ? IEEE80211_NWID_LEN : 14; >> +    ssidmax = verbose ? IEEE80211_NWID_LEN : 32; > > IEEE80211_NWID_LEN is 32, so this says ‘verbose ? 32 : 32’ now. > >>      printf("%-*.*s  %-17.17s  %4s %4s   %-7s  %3s %4s\n" >>          , ssidmax, ssidmax, "SSID/MESH ID" >>          , "BSSID" > > Regards, > Kristof > It seems like what you were looking for was just 'ifconfig -v scan' I think the reason it is limited to 14, is so that it will fit in 80 col wide terminals in non-verbose mode. -- Allan Jude