Date: Wed, 6 Nov 2013 06:54:05 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Martin Matuska <mm@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r332649 - in head/net-p2p: . cpuminer Message-ID: <20131106065405.GD60770@FreeBSD.org> In-Reply-To: <201311032121.rA3LL2T0050646@svn.freebsd.org> References: <201311032121.rA3LL2T0050646@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Nov 03, 2013 at 09:21:02PM +0000, Martin Matuska wrote: > New Revision: 332649 > URL: http://svnweb.freebsd.org/changeset/ports/332649 > > Log: > cpuminer is a simple daemon that performs Bitcoin or Litecoin > pooled or solo mining. The port is generally quite clean, thank you. > WWW: http://sourceforge.net/projects/cpuminer/ > > +LIB_DEPENDS= curl:${PORTSDIR}/ftp/curl \ > + jansson:${PORTSDIR}/devel/jansson You could've used modern LIB_DEPENDS syntax. > +USE_GITHUB= yes > +GH_ACCOUNT= pooler > +GH_TAGNAME= v${PORTVERSION} > +GH_COMMIT= 8b30b7b May I ask why GitHub snapshots are preferred over SF.net official tarballs? > +USE_AUTOTOOLS= aclocal autoheader automake autoconf > +AUTOMAKE_ARGS= --gnu --add-missing --copy > +GNU_CONFIGURE= yes GNU_CONFIGURE is redundant in presence of all those auto* tools in USE_AUTOTOOLS. > +.include <bsd.port.options.mk> > + > +.include <bsd.port.pre.mk> Just one of them is enough. > +.if ${OSVERSION} > 1000000 > +USE_GCC= yes > +.endif How hard would it be to unbreak the port across all FreeBSD versions and compilers? In many cases it's a matter of a simple patch, or CFLAGS with -Wno-<something> switch(es). > +post-install: > +.if ${PORT_OPTIONS:MDOCS} > + @${MKDIR} ${STAGEDIR}${DOCSDIR}/ > +.for FILE in NEWS README > + ${INSTALL_DATA} ${WRKSRC}/${FILE} ${STAGEDIR}${DOCSDIR}/ > +.endfor > +.endif Checking for PORT_OPTIONS:MDOCS in simple cases like this one (docs are not being built nor insanely heavy) can (and should) be dropped. Just make the directory and install them there. It would also allow you from the need to include <bsd.port.options.mk> (assuming OSVERSION reference can be removed). > @@ -0,0 +1 @@ > +bin/minerd One-lined pkg-plist? Why not use PLIST_FILES knob? ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131106065405.GD60770>