From owner-cvs-src@FreeBSD.ORG Thu Jul 12 08:20:32 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3C39116A484 for ; Thu, 12 Jul 2007 08:20:32 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from nz-out-0506.google.com (nz-out-0506.google.com [64.233.162.237]) by mx1.freebsd.org (Postfix) with ESMTP id 980E713C483 for ; Thu, 12 Jul 2007 08:20:27 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: by nz-out-0506.google.com with SMTP id l8so59934nzf for ; Thu, 12 Jul 2007 01:20:26 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=OC/V0oRD4pcvFSAd661SseKLVySz0NXna8hLcIUuNUFKR8Rp7C+Nbfn0q6qjiOZL4dO7aPs6Mt34GQIBvWjI1GzZtlkSLUsC9trAT1fyQwOZcsPiu/sEzcRboH78KEtSgZ18W7sH9YqDlpi2dqr9eC18dMwRr4KUM9kNylmnmAI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=jGZTajY2cd3CsEhu1RjQ3A2cqPeVMq1nhGqMIHsLNrWyPaqlwb8Kb0RndlvEzyv6gd5q0oVDhpaihPVkzWXFXTrBTujI3V+60w1UuxUbyrjgHVpZIhRgeaWMZrOtS2KVv1ulLO0XJfd2Lnnth3FxnO+MeVBEozSq7ifYpRvZgTQ= Received: by 10.114.134.1 with SMTP id h1mr371737wad.1184228426394; Thu, 12 Jul 2007 01:20:26 -0700 (PDT) Received: by 10.114.103.14 with HTTP; Thu, 12 Jul 2007 01:20:26 -0700 (PDT) Message-ID: <2a41acea0707120120w38d67d7fsf01d573329814c4@mail.gmail.com> Date: Thu, 12 Jul 2007 01:20:26 -0700 From: "Jack Vogel" To: "Robert Watson" In-Reply-To: <20070712085707.G68820@fledge.watson.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200707112303.l6BN3HPu010363@repoman.freebsd.org> <20070712085707.G68820@fledge.watson.org> Cc: Jack F Vogel , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/ixgbe LICENSE ixgbe.c ixgbe.h ixgbe_82598.c ixgbe_api.c ixgbe_api.h ixgbe_common.c ixgbe_common.h ixgbe_osdep.h ixgbe_phy.c ixgbe_phy.h ixgbe_type.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2007 08:20:32 -0000 Sorry, what happened was the first commit accidentally only included the conf files, so I followed this up right after with a sheepish joke, I should've added the comment from the first, my bad :( On 7/12/07, Robert Watson wrote: > On Wed, 11 Jul 2007, Jack F Vogel wrote: > > > jfv 2007-07-11 23:03:17 UTC > > > > FreeBSD src repository > > > > Added files: > > sys/dev/ixgbe LICENSE ixgbe.c ixgbe.h ixgbe_82598.c > > ixgbe_api.c ixgbe_api.h ixgbe_common.c > > ixgbe_common.h ixgbe_osdep.h ixgbe_phy.c > > ixgbe_phy.h ixgbe_type.h > > Log: > > Add the actual source too :) > > This commit message leaves a lot to be desired, especially for 1.1 revisions. > I think you should consider a forced commit that mentions something more than > that the files are source code -- perhaps a 2-3 level sentence summary of what > the actual change meant. Remember that changes on other files, such as the > conf files you touched in the earlier commit, won't appear in "cvs log" of > these files. > > Robert N M Watson > Computer Laboratory > University of Cambridge >