From nobody Fri Aug 8 17:39:14 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bzB9H3XjJz64GYf; Fri, 08 Aug 2025 17:39:15 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bzB9H2fVlz4F74; Fri, 08 Aug 2025 17:39:15 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754674755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wVrtSziFfW9ZvtHTP7o5oO0hlQeQNsPPHqD15D4qUnw=; b=QCN4TeprKI/mGFtlh4QK34XrnqaETXtfbiOnbi1wNzh7yALmkmwWq+erto9oud5XBL33WQ yu3YoN3ROk71R9efRsGi3UYg2be6OHf1zDIpdFeaMPtArlmT0YDqhcf5XsKb3KnmvJf5HR KLbAzKxwiwvLhjDdWOfBE7Ln0SDJZeUxYva/rlMTYhvdW/9WbFtWrUfB7wacIzulAcuFjK Xr512vphKJy9LbKw+jmCeZ9ceoQnshUMpyT9UGwu7bKYL+4IFir6kYJd02CQI2Kwj8+VD3 3jszkt/CrTinDs7DceNEisQVObomy0IwOl8Q86Qe3v+2JCq3//JSjZ4oskttyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754674755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wVrtSziFfW9ZvtHTP7o5oO0hlQeQNsPPHqD15D4qUnw=; b=xY4Z+koRL7TTfcvhX64DwUHVyz1rHTkpRmaafgnIuPOGieJlfdwBEgsoEIwNPA6UnTsoSa qY7Tmio3+l8SmcvjWiKkCIgLu1N/hzO5rHxNa9p9Rlqcsobj5ZbznKwX7X5cF0xjoyEH8G DaRb2ILL29749wj6zs6gc1avFts85Xt/M6oTSzJPsH8dXbqIZQkjU/cKLsMH70GVMg21/n 8BfZ9efLGDhgWL5jpQx2M3neypsbJrNBU4JVDOava7ICrnS6e/IaHL4N5exF8rz4sgO9RJ 725qcPdqMSgzJaFMM6iXg7hDKMoFhAXpb/S4K0LM2JEmCdQVk/cngY4i24emLA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1754674755; a=rsa-sha256; cv=none; b=elNQU/2NENup0/MhsoFor36HilkBt+xUwXTGU9GrkR2b5vo38ktH4SKkZBFPgPF5nnffox CNOqYaDvzQ0GwMjn1L+6tIsXzDCvsP+smDs2eYJVFs91nsbasbxw+W9YoOC48UTw6vU7Z1 r/qP+JaeD5105eQX1g7K6efGNaehgdBkqXm3I3glspWs/av5bYpug8hfnKFvhVbnwvyU9O xHaEjZXXxNSEaAbrLvrtexr1fURZq/xDQ/4xZ3xpxx2om0n9Tzi/D5Rfo6MkMp3xAf0MIA WfSU5m9k+T/IKt32tjKeSOL5dxN3wFLLmkjzMucpkhawecB8fZFKOf0fhvYh+w== Received: from [IPV6:2601:5c0:4202:5670:885d:b51:24c2:bf83] (unknown [IPv6:2601:5c0:4202:5670:885d:b51:24c2:bf83]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4bzB9H0Q8yzMwX; Fri, 08 Aug 2025 17:39:15 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <6bc73e1a-03f7-4845-9890-97a7afd68f12@FreeBSD.org> Date: Fri, 8 Aug 2025 13:39:14 -0400 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 6dab48b9de6c - main - build: Switch CLEAN back on by default Content-Language: en-US To: =?UTF-8?Q?Dag-Erling_Sm=C3=B8rgrav?= , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202508081559.578FxjHP094672@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 8/8/25 12:37, Philip Paeps wrote: > On 2025-08-08 15:59:45 (+0000), Dag-Erling Smørgrav wrote: >> The branch main has been updated by des: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=6dab48b9de6c1bff61b0ce78029c1e3cba20895a >> >> commit 6dab48b9de6c1bff61b0ce78029c1e3cba20895a >> Author: Dag-Erling Smørgrav >> AuthorDate: 2025-08-08 15:57:31 +0000 >> Commit: Dag-Erling Smørgrav >> CommitDate: 2025-08-08 15:57:31 +0000 >> >> build: Switch CLEAN back on by default >> >> There have been too many issues with non-META_MODE incremental builds >> recently, and it is clear that most users, even developers, were not >> aware that the default had been switched. >> >> This will be revisited once more work has been done to help prevent >> future breakage. >> >> This reverts commit ba373fca78a114768244d6a8c27983da870c1169. >> >> Reviewed by: markj, jhb >> Differential Revision: https://reviews.freebsd.org/D51828 > > Thank you! > > Maybe we should just flip CLEAN on for a couple of days/weeks when > there's something disruptive on main that benefits from thorough > cleaning, but have it off by default? > > As I understand it, doing pkgbase builds with CLEAN rebuilds all > packages, and pkg will want to update them even if the binaries within > are unchanged. We set WITHOUT_CLEAN=1 in the cluster pkgbase builder to > try to make sure that doesn't happen. > > I would love to put that flag under developers' control so pkgbase > package production doesn't stall when a WITH_CLEAN=1 build is needed. CheriBSD has a .require_clean_build flag that effectively can be used to force clean builds in extreme cases based on a cached cookie value saved in .OBJDIR. CheriBSD's version is checked by a python wrapper script, but a similar mechanism could be used in FreeBSD that was checked by depend_cleanup.sh perhaps when we need a bigger hammer. -- John Baldwin