Date: Sat, 23 Nov 2019 16:30:45 +0100 From: Adriaan de Groot <adridg@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r518243 - head/x11-toolkits/qt5-gui Message-ID: <8680887.Jb6mJC18hs@reneon> In-Reply-To: <20191123145524.GA84936@FreeBSD.org> References: <201911231446.xANEkdSZ075924@repo.freebsd.org> <20191123145524.GA84936@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart1695823.fVUeUJyjye
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
On Saturday, November 23, 2019 3:55:24 PM CET Alexey Dokuchaev wrote:
> > +RUN_DEPENDS= xdg-open:devel/xdg-utils \
> > + ${LOCALBASE}/include/vulkan/vulkan.h:devel/vulkan-headers
>
> Commit log does not really explain how come a *header file* is needed
> at runtime. If the problem is with `sysutils/qt5-qtdiag', shouldn't it
> be fixed instead?
Every consumer of qt5-gui would (potentially) need a BUILD_DEPENDS on vulkan
headers. This seemed easier. Possibly RUN_DEPENDS is a bad choice; I'd put
this in LIB_DEPENDS except that it's a headers-only dependency.
> Also, previously when Vulkan headers were only a bdep I didn't raise
> the question about why it was not made OPTIONal, but I do now. There
> are plenty of Qt5 users who would likely never want to have any Vulkan
> bits on their systems.
Since this is a headers-only dependency which is only a few kB in size, we
(kde@) decided to just install it rather than mess around with trying to make
it OPTIONAL.
[ade]
--nextPart1695823.fVUeUJyjye
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEUq+pvuD+N8/vVW++WoDe9T7W/7IFAl3ZUKUACgkQWoDe9T7W
/7I7Gg//b2P2DK3o0haiPJX1tOwX4SqIdAOoh9sqy+vkX05G5iLbgWJbzWTF5aRV
z0iJel2xnQMjCf+xz+NpbyMBoY0Z21mRQ4GSIyjHrowjKy2+wCNBxg/RQRUjQAY8
KDA9FZH1iB8kwGuYkSFYS7EiqlKLW6vlTFiaj81yKZIkKKTbN1/865donvg8Tshk
nvRTd2vkeMiqY3UDsf2eE/5cBYWJBbd5R/PETjE/3mWDEgqTruG2n9pmq038oKDi
un5igDpWdWSnPWmleth8fMFUMAFn8xet0ClIjdKR7VrcQMf3XqOmXz4UabPnVohK
XiMyO7Qq1/U0u6obUjXlZ+s++k2fYDbuTwNbZApR/9mX/x3jhxbcPSCfrO9bjrVJ
zy8jP0jokeAiy5Pvoc5btkopGvUmAkWA6DCqRrPHKDCzFuQZRNMIMf64OWKMX2Au
22rmhUP0kywoXncJfyllmMl2vy+0IZOYfC8U37ru6rBhV0dT6/ke/dAeQjYQPcBG
hGweU3BKWywdlyA0JcysiPmUcqxs8NbBv2X3aX7yGmCRh6OARzUZFaMEqX8JIFjm
LRF9CsQ9db+dZyxKVaf7Jgd3mycei54xNg7m90k1t+TYFISHON+BfyE9nGepLymg
GdP0qQCGwL7TrprSnyzqAEEYE+5vRfC+yJeP0Q1YjAj0uz3DbHQ=
=6+FB
-----END PGP SIGNATURE-----
--nextPart1695823.fVUeUJyjye--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8680887.Jb6mJC18hs>