From owner-freebsd-current@freebsd.org Fri Jan 4 19:15:00 2019 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 13A051436284 for ; Fri, 4 Jan 2019 19:15:00 +0000 (UTC) (envelope-from manfredantar@gmail.com) Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E35B4777C4; Fri, 4 Jan 2019 19:14:58 +0000 (UTC) (envelope-from manfredantar@gmail.com) Received: by mail-pl1-x632.google.com with SMTP id t13so17807029ply.13; Fri, 04 Jan 2019 11:14:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:content-transfer-encoding:mime-version:subject:message-id:date :cc:to; bh=s/LbOVzKk3OKqC+lfpMM1Ii8jhkdiloOzf2XY2Ljy0Y=; b=ZX1GASerQVFbrIafbUA2x6hDMyBC99pWTMytax6+FSABAqg7k4vzc+9SkgvHnWjnxB xaWOgHvVgMPKBZtnU/cJ0Tt1GSKvkIR8/ieSemRQoHTt+YuxUb2LZU806fGVS7fgy3Lb 98X32A6T0xjsujOjGcSIdlh1tRJQE1cJVn6qJJVzSaCjNhrqsPlvvoMvhwiGeA7XEzye 2ZIM/0e5g9jZITRZgXx+xCaA55aj5LzWgBeDWWYmhxXmYaZB4taeIz+hUjYjC+XWoI1f qyqNjOXjcdHtIxsIsJUVtbJyb5q+3nrx3sv7A0mp66WTry478S6S4Ov+g0oUPPfrCq/P DBdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:cc:to; bh=s/LbOVzKk3OKqC+lfpMM1Ii8jhkdiloOzf2XY2Ljy0Y=; b=G2F/JDE7lJF8iAg9AUNrgwxtxrqU8c0tnb+Fb1anhHKt8nPut5zv/CikCm7WuJRQmI 0L7Ee6zKUESAwHTTyOEwvKPmokFHBJQ47Hyr5Em1mK4zvJkrH3zgnndtemg49YDiJwXT F/05/vjjEk6Qs7iyRP9dX+N/Lt2z/B6oImD+nFCGTbpnxw7z3D6H1R1sRsHfD2owDnVK FVz5RNptZuQEt5Begs19sGslY+L5ysreAEE0ExdylvXfVSK9SrTm6/hoYAwYZHg5CCmm tayrBEQJrcvrKCA+iVNfx0cZlnBlBZhqifHBqY0MGD0UqArbMYttTxX2K+fvG3xArr3u aXMA== X-Gm-Message-State: AJcUukdBizBsDF3AAaxeBTru3GhIsxAYs2LLvYuKOHrdt2trAFJY//Lq 3tx/8rnUSSkzkObA2MQXfCwXJEdPg+11gw== X-Google-Smtp-Source: ALg8bN5RDydV9OjYvqtxYcInTI7l+sbDJzRPrLlnSrVepVTn99gS6JJHw0xAhrITDTFpY1FWt2glqA== X-Received: by 2002:a17:902:209:: with SMTP id 9mr52768179plc.288.1546629297510; Fri, 04 Jan 2019 11:14:57 -0800 (PST) Received: from octo.pozo.com (50-197-129-138-static.hfc.comcastbusiness.net. [50.197.129.138]) by smtp.gmail.com with ESMTPSA id c9sm114190663pfc.92.2019.01.04.11.14.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Jan 2019 11:14:56 -0800 (PST) From: Manfred Antar Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: revision 342699 breaks savecore when WITHOUT_DYNAMICROOT=yes is defined in src.conf amd64 current Message-Id: <37342A59-3F95-45A3-8B84-09750E31E325@gmail.com> Date: Fri, 4 Jan 2019 11:14:55 -0800 Cc: markj@freebsd.org, Conrad Meyer , oshogbo@freebsd.org To: FreeBSD Current X-Mailer: Apple Mail (2.3445.102.3) X-Rspamd-Queue-Id: E35B4777C4 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=ZX1GASer; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of manfredantar@gmail.com designates 2607:f8b0:4864:20::632 as permitted sender) smtp.mailfrom=manfredantar@gmail.com X-Spamd-Result: default: False [-4.27 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; FREEMAIL_FROM(0.00)[gmail.com]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.98)[-0.978,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(-0.78)[ipnet: 2607:f8b0::/32(-2.18), asn: 15169(-1.66), country: US(-0.08)]; RCVD_IN_DNSWL_NONE(0.00)[2.3.6.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2019 19:15:00 -0000 sbin/savecore broken when WITHOUT_DYNAMICROOT is defined: /usr/local/bin/ccache cc -O2 -pipe -DWITH_CASPER -MD = -MF.depend.savecore.o -MTsavecore.o -std=3Dgnu99 = -fstack-protector-strong -Wsystem-headers -Wall -Wno-format-y2k -W = -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes = -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch = -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline = -Wnested-externs -Wredundant-decls -Wold-style-definition = -Wno-pointer-sign -Wmissing-variable-declarations -Wthread-safety = -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable = -Qunused-arguments -c /usr/src/sbin/savecore/savecore.c -o savecore.o cc -O2 -pipe -DWITH_CASPER -std=3Dgnu99 -fstack-protector-strong = -Wsystem-headers -Wall -Wno-format-y2k -W -Wno-unused-parameter = -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type = -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter = -Wcast-align -Wchar-subscripts -Winline -Wnested-externs = -Wredundant-decls -Wold-style-definition -Wno-pointer-sign = -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body = -Wno-string-plus-int -Wno-unused-const-variable -Qunused-arguments = -static -o savecore savecore.o = -L/usr/obj/usr/src/amd64.amd64/lib/libxo -lxo = -L/usr/obj/usr/src/amd64.amd64/lib/libutil -lutil = -L/usr/obj/usr/src/amd64.amd64/lib/libz -lz = -L/usr/obj/usr/src/amd64.amd64/lib/libcasper/libcasper -lcasper = -L/usr/obj/usr/src/amd64.amd64/lib/libnv -lnv = -L/usr/obj/usr/src/amd64.amd64/lib/libcap_fileargs -lcap_fileargs = -L/usr/obj/usr/src/amd64.amd64/lib/libnv -lnv = -L/usr/obj/usr/src/amd64.amd64/lib/libcasper/services/cap_syslog = -lcap_syslog -L/usr/obj/usr/src/amd64.amd64/lib/libnv -lnv ld: error: unable to find library -lcasper ld: error: unable to find library -lcap_fileargs ld: error: unable to find library -lcap_syslog cc: error: linker command failed with exit code 1 (use -v to see = invocation) *** Error code 1 Stop. make: stopped in /usr/src/sbin/savecore The recent change r342699 breaks static link: .include =20 .if ${MK_CASPER} !=3D "no" && !defined(RESCUE) CFLAGS+=3D -DWITH_CASPER LIBADD+=3D casper cap_fileargs cap_syslog .endif I think something like this is needed to when defining = WITHOUT_DYNAMICROOT: .include .if ${MK_CASPER} !=3D "no" && !defined(RESCUE) && = !defined(WITHOUT_DYNAMICROOT) CFLAGS+=3D -DWITH_CASPER LIBADD+=3D casper cap_fileargs cap_syslog .endif Manfred=