From owner-svn-ports-all@FreeBSD.ORG Mon Nov 26 17:08:22 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 66F13721; Mon, 26 Nov 2012 17:08:22 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from winston.madpilot.net (winston.madpilot.net [78.47.75.155]) by mx1.freebsd.org (Postfix) with ESMTP id 1884A8FC13; Mon, 26 Nov 2012 17:08:21 +0000 (UTC) Received: from winston.madpilot.net (localhost [127.0.0.1]) by winston.madpilot.net (Postfix) with ESMTP id 3Y9F261CFCzFT9x; Mon, 26 Nov 2012 18:08:14 +0100 (CET) X-Virus-Scanned: amavisd-new at madpilot.net Received: from winston.madpilot.net ([127.0.0.1]) by winston.madpilot.net (winston.madpilot.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iZGIVBMVGRWt; Mon, 26 Nov 2012 18:08:08 +0100 (CET) Received: from vwg82.hq.ignesti.it (unknown [80.74.176.55]) by winston.madpilot.net (Postfix) with ESMTPSA; Mon, 26 Nov 2012 18:08:08 +0100 (CET) Message-ID: <50B3A1F9.5060904@FreeBSD.org> Date: Mon, 26 Nov 2012 18:08:09 +0100 From: Guido Falsi User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Eitan Adler Subject: Re: svn commit: r307782 - head/audio/asunder References: <201211261259.qAQCxdXD089022@svn.freebsd.org> <20121126135609.GC62928@FreeBSD.org> <50B39163.2040309@FreeBSD.org> <20121126161113.GA72036@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2012 17:08:22 -0000 On 11/26/12 17:57, Eitan Adler wrote: > On 26 November 2012 11:11, Alexey Dokuchaev wrote: >> On Mon, Nov 26, 2012 at 04:57:23PM +0100, Guido Falsi wrote: >>> On 11/26/12 14:56, Alexey Dokuchaev wrote: >>>> We have standard knob for this one (APE_DESC). >>>> >>>>> PORTDOCS= AUTHORS COPYING ChangeLog INSTALL NEWS README TODO >>>> >>>> Normally we do not install COPYING as part of the docs, LICENSE should be >>>> set instead. If software expects to find this file (e.g. for displaying in >>>> the about dialog), it should be redirected to share/licenses/${PKGNAME} >>>> instead (see `graphics/luminance' port for an example). >>> >>> Thanks for these, I'll fix them and commit after maintainer approval. >> >> Technically speaking, you don't have to have maintainer's approval for these >> things, as they don't affect functionality, just make the port more adhering >> to our standards (and common sense). > > It is good to ping the maintainer though unless there is specific reason not to. > - Since they signed up to maintain the port its nice not to change > things without asking > - It teaches the maintainers about our standards :) I agree. I'd rather ping them if the problem is not really urgent(i.e. broken index, broken dependencies etc.) or really really trivial (i.e. typo, fixing a comment/header). Anyway if I don't get an answer in a decent time I'll go ahead and fix this anyway. -- Guido Falsi