From owner-cvs-src@FreeBSD.ORG  Sun Nov 14 15:45:36 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9B2B316A4CE; Sun, 14 Nov 2004 15:45:36 +0000 (GMT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id DF3D043D1F; Sun, 14 Nov 2004 15:45:35 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id iAEFjXNc051925;
	Sun, 14 Nov 2004 16:45:34 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: Maxim Sobolev <sobomax@portaone.com>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Sun, 14 Nov 2004 17:42:04 +0200."
             <41977CCC.8070607@portaone.com> 
Date: Sun, 14 Nov 2004 16:45:33 +0100
Message-ID: <51924.1100447133@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: cvs-src@FreeBSD.ORG
cc: src-committers@FreeBSD.ORG
cc: cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/usr.bin/make job.c job.h main.c make.c 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Nov 2004 15:45:36 -0000

In message <41977CCC.8070607@portaone.com>, Maxim Sobolev writes:

>Great job! However I wonder if use of pipe(2) would be better way, which 
>will not leave any traces behind it in the case when all makes die in a 
>way that prevents them from taking clean up actions (e.g. kill -9).

That's how gmake does it, and it is no end of trouble because you
have to hope for the file descriptors to survive open through shell
scripts and other gunk.  And passing the numeric filedescriptors
in an environment variable is wrong in all ways it possibly can be.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.