From owner-freebsd-bugs Wed Dec 2 01:31:25 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id BAA29112 for freebsd-bugs-outgoing; Wed, 2 Dec 1998 01:31:25 -0800 (PST) (envelope-from owner-freebsd-bugs@FreeBSD.ORG) Received: from arc.hq.cti.ru (arc.hq.cti.ru [195.34.40.3]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id BAA29099 for ; Wed, 2 Dec 1998 01:31:23 -0800 (PST) (envelope-from tejblum@arc.hq.cti.ru) Received: from arc.hq.cti.ru (localhost [127.0.0.1]) by arc.hq.cti.ru (8.9.0/8.9.0) with ESMTP id MAA19641; Wed, 2 Dec 1998 12:28:39 +0300 (MSK) Message-Id: <199812020928.MAA19641@arc.hq.cti.ru> X-Mailer: exmh version 2.0zeta 7/24/97 To: dg@root.com cc: Dmitrij Tejblum , freebsd-bugs@FreeBSD.ORG Subject: Re: mmap of large files In-reply-to: Your message of "Tue, 01 Dec 1998 21:45:42 PST." <199812020545.VAA03985@root.com> Date: Wed, 02 Dec 1998 12:28:38 +0300 From: Dmitrij Tejblum Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org > >Does the test > > if ((pos + size > (vm_offset_t)-PAGE_SIZE) || > >in the mmap syscall have any purpose, other than break mmap with > >pos > 4GB? > > I think the code is wrong. I think it should be (addr + size) and comparing > against -PAGE_SIZE is probably also wrong - careful attention needs to be > paid to rounding and overflow issues here. Needs more analysis. > I think, vm_map_insert test for validity of (addr + size), no? Dima To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message