From owner-svn-src-all@freebsd.org Sat Jun 9 17:16:53 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4AEDF1011E91 for ; Sat, 9 Jun 2018 17:16:53 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B493785421 for ; Sat, 9 Jun 2018 15:56:03 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: from mail-yw0-f173.google.com (mail-yw0-f173.google.com [209.85.161.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: eadler) by smtp.freebsd.org (Postfix) with ESMTPSA id 82D05223B4 for ; Sat, 9 Jun 2018 15:56:03 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: by mail-yw0-f173.google.com with SMTP id q7-v6so5061375ywd.9 for ; Sat, 09 Jun 2018 08:56:03 -0700 (PDT) X-Gm-Message-State: APt69E2CEWH90br39JlbxHffmOVIGPu6h+0cmv25vV2CnZsJdrtaOitY Qq3RLvpNXz0hTolD5HHiOL2FrHg/zI6lPyYB7h+xYQ== X-Google-Smtp-Source: ADUXVKLa9zIFWJk7/Ih9G4BpJor4fwrTaR+wynL+J1CDm1BNNvm1A5NVsl67+HTw85gHA3Y9k6grZRtWQ3ZNMRUzddo= X-Received: by 2002:a0d:cf01:: with SMTP id r1-v6mr6009547ywd.162.1528559763216; Sat, 09 Jun 2018 08:56:03 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:ef50:0:0:0:0:0 with HTTP; Sat, 9 Jun 2018 08:55:32 -0700 (PDT) In-Reply-To: References: <201806090214.w592EYsJ056425@repo.freebsd.org> <06a78fe9-defe-d798-3764-4f1df521538f@smeets.xyz> From: Eitan Adler Date: Sat, 9 Jun 2018 08:55:32 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r334864 - head/usr.bin/top To: Florian Smeets Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jun 2018 17:16:53 -0000 On 9 June 2018 at 08:54, Eitan Adler wrote: > On 8 June 2018 at 23:13, Florian Smeets wrote: >> On 09.06.18 04:14, Eitan Adler wrote: >>> Author: eadler >>> Date: Sat Jun 9 02:14:33 2018 >>> New Revision: 334864 >>> URL: https://svnweb.freebsd.org/changeset/base/334864 >>> >>> Log: >>> top(1): use a different command to toggle tid vs pid >> >> Thank you. >> >> You cannot start top with -T unless you add something like the following: > > I have a patch out for this, but svn is having issues right now (or at > least I am). > >> Another issue I just found is that if you start top with -P some columns >> don't show any values: > >> >> It is correct if you start top with -TP or -HP, or if you start top -P >> and then use H or T to switch back and forth. I'm not sure in which >> revision this was broken, it works with r333899. > > I'm guessing this is because I forgot to initalize "prehead" > somewhere. I'd like to rewrite the entire header creation, but will > try and fix this. Thanks for the report! By header, I meant header and data format string :) -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams