From owner-freebsd-current@FreeBSD.ORG  Thu Mar 26 17:45:44 2015
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 20C4F888
 for <freebsd-current@freebsd.org>; Thu, 26 Mar 2015 17:45:44 +0000 (UTC)
Received: from mail-ie0-x234.google.com (mail-ie0-x234.google.com
 [IPv6:2607:f8b0:4001:c03::234])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id DB70FE2D
 for <freebsd-current@freebsd.org>; Thu, 26 Mar 2015 17:45:43 +0000 (UTC)
Received: by iedm5 with SMTP id m5so52509151ied.3
 for <freebsd-current@freebsd.org>; Thu, 26 Mar 2015 10:45:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=rFwGRrFykxSefx8S2hyC1zVOs7OcGmPK4RRp70hEB2I=;
 b=DJdCIIOgtGYKICvc5moJdstPgiJxF5k+0Lx716iMMyUT9i6vMs+nBJLCiaQQEM7OCa
 kLEOeW+XuumliGzzszDD0KJpo4sD5+PaRmSvitxdXU/l9s8MYMPHpsshuVSjO+Bw0L+K
 UW1uEow324DH9ubSpTsWNjgwAv21V55VAnDR/BhZNrAlKVg3wNdq4pdQrqqxR0dRl2jI
 7jpBx8UAeALJQshrhs8qt67/QM+DYL6xgvatdi0im0zEIPlZ5I6Lj4RFv5wTGy4rQKXg
 Ynl+EHNFZtVX9OYPDo1R8uKZllo6vL7FL9aKVrgDBnVOWQ3gMhCZUDv1D/q0G0FnVTNy
 udqg==
MIME-Version: 1.0
X-Received: by 10.50.107.7 with SMTP id gy7mr38500126igb.49.1427391943267;
 Thu, 26 Mar 2015 10:45:43 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.36.17.194 with HTTP; Thu, 26 Mar 2015 10:45:43 -0700 (PDT)
In-Reply-To: <1708955.mQ2X6OUmTD@pc-alex>
References: <1708955.mQ2X6OUmTD@pc-alex>
Date: Thu, 26 Mar 2015 10:45:43 -0700
X-Google-Sender-Auth: bgKZICZykryCSvWJA8fpXzZCZfw
Message-ID: <CAJ-Vmon+xBTJ-gjOiFb5y13NchDOvU_FmBwX473s0_=CsMmhfA@mail.gmail.com>
Subject: Re: Mbuf leak in if_lagg.c
From: Adrian Chadd <adrian@freebsd.org>
To: Alexandre Martins <alexandre.martins@stormshield.eu>
Content-Type: text/plain; charset=UTF-8
Cc: freebsd-current <freebsd-current@freebsd.org>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Mar 2015 17:45:44 -0000

Hi!

Please file a bug! https://bugs.freebsd.org/submit/

Thanks!


-a


On 19 March 2015 at 09:31, Alexandre Martins
<alexandre.martins@stormshield.eu> wrote:
> Hi !
>
> I found a leak of mbuf in the lagg driver :
>
> https://svnweb.freebsd.org/base/head/sys/net/if_lagg.c?view=annotate#l1672
>
> -=-=-=-=-=-=-=-=-=-=-
> m = (lp->lp_detaching == 0) ? lagg_proto_input(sc, lp, m) : NULL;
> -=-=-=-=-=-=-=-=-=-=-
>
> If lp_detaching is non 0, the mbuf pointer is set to NULL without m_freem it.
>
> Can you look at this ?
>
> Regards
>
> --
> Alexandre Martins
> STORMSHIELD
>