From owner-svn-src-head@freebsd.org Tue Nov 27 00:03:45 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8DD2611497C3 for ; Tue, 27 Nov 2018 00:03:45 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E68A4725FB for ; Tue, 27 Nov 2018 00:03:44 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1543276051; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=J4/mqAWeVMr8gvI85R54lXvjlkx3lCRmmZnhPjVN2MefJwG4cRwU4H0zVCv2BhOiw5wVSWlA4MJF/ 7Pl/NhvFbTC5Af0YC2HL+vPbSFByJ0PYw1Fy4qfNcsJlKdcqSW1F7Ja8Yr55NrH6MeZlwhdo5BHgfQ NpN27qgj6DuuUlp0+B1qqSE5kGzlePxM+YdtzT6kWuFo2YkVx4TkjfbZqgnTs09CEtsAHVAYG+SaTJ /VviegbMQhPr7R1yKrR2dKXTRJrN6nrcuQXbb+/2UzOxg/pCRv6r4g/q5+s7uMtmmRGOu6Xn5mIAxq Lrjlhj+nrWuCjmrgi3KTTGAl5h7Omzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=VQYL9dtPdXg0y1OfohC5ggOz04B8CSYeSRS09kUb2ZU=; b=Wd1ByM84/MrJA6OvWIwXrz2teXEMyl8/1lncCIBoRhQgGrO7L8VCM1uuKOqExw6XIClH++YxslMVd YdJsCIO5//rU+w50oOWZQTMupgr60lS5SP+wr8jFpr2caxX+dRpf/oeZQOqFD8/M4EEuibQSOR+T+E UER98nGFWcnq5BCKIlllMwDW28UVgPpZs34oTUKUXFeWe5N/Dx0urSVSBQ6Als4QWm1iWqdQ8rYSuY VGVXx6ve541COyM4ALe5g5/WUmJ1iYzLndI99ERHrLKDcPs+7W5SX2fe7Mxu1Lp3K+Iy63Y0vOc3eN uXfv2nuabruhB64sLFtDuQoS22ZuOcg== ARC-Authentication-Results: i=1; outbound2.eu.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=VQYL9dtPdXg0y1OfohC5ggOz04B8CSYeSRS09kUb2ZU=; b=nN8L8LR6yRCr23OtLbWxbRQ7zajY29ZeYWdLOwbkwpJ6yBURdknwnNHEYFUnU6mM7gfodPNunvELY PazJea8jgksie1oXks37dH7yfhW5fav42rJBuf3+3kC2dtpFDE7leX7UkXDdOW5Bqe305O7bau2zsq hL6U3DY1WR2LxGfwOSmqpzQcs3FvquNNZWpo/+y45x7WqhKaoErlNsOjjoK0EsZX5TkVajGS1+jz/+ LXjEsM3v6bbggXNRTfqxmbL79m4SahvL+E5T54Ov2DLsEok9eF03EONTVjW5297HU1VxYwNzlJx9gD hKJ0BvuGZ95Q/w0cCLDhk24hGYuQLww== X-MHO-RoutePath: aGlwcGll X-MHO-User: a2303759-f1d5-11e8-a887-bd2f23b465e5 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound2.eu.mailhop.org (Halon) with ESMTPSA id a2303759-f1d5-11e8-a887-bd2f23b465e5; Mon, 26 Nov 2018 23:47:30 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id wAQNlSpk032481; Mon, 26 Nov 2018 16:47:28 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1543276048.1860.29.camel@freebsd.org> Subject: Re: svn commit: r340617 - head/sys/netgraph From: Ian Lepore To: Eugene Grosbein , John Baldwin , src-committers@freebsd.org, svn-src-head@freebsd.org Date: Mon, 26 Nov 2018 16:47:28 -0700 In-Reply-To: <47a21d5b-f0a9-cd23-a5f4-870aabd09995@freebsd.org> References: <201811190727.wAJ7RpDN052165@repo.freebsd.org> <5e7d2e8e-2a06-e687-f4c1-5c30ee4c50be@freebsd.org> <1543275344.1860.28.camel@freebsd.org> <47a21d5b-f0a9-cd23-a5f4-870aabd09995@freebsd.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: E68A4725FB X-Spamd-Result: default: False [0.48 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_SPAM_SHORT(0.03)[0.026,0]; NEURAL_SPAM_MEDIUM(0.14)[0.138,0]; NEURAL_SPAM_LONG(0.31)[0.314,0]; ASN(0.00)[asn:16509, ipnet:52.58.0.0/15, country:US] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2018 00:03:45 -0000 On Tue, 2018-11-27 at 06:45 +0700, Eugene Grosbein wrote: > 27.11.2018 6:35, Ian Lepore wrote: > > > > > > > > > > > > > > #ifdef __LP64__ > > > >     { "tv_usec",        &ng_parse_int32_type }, > > > > #else > > > >     { "tv_usec",        &ng_parse_int64_type }, > > > > #endif > > > I'm not sure I get it right: do you mean there is a difference > > > for > > > some platform we have? > > I think there's a typo there... it makes more sense if the second > > test > > is #ifndef __LP64__ (or swap the 32 and 64 in the true/false legs > > of > > the test as shown). > That was obvious typo :-) and my question was not about it. > Hrm, then what is your question? It seems like the suggested code is self-explanatory with the typo corrected. -- Ian