From owner-cvs-all Mon Jun 4 15:19:41 2001 Delivered-To: cvs-all@freebsd.org Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by hub.freebsd.org (Postfix) with ESMTP id 12B6A37B401; Mon, 4 Jun 2001 15:19:32 -0700 (PDT) (envelope-from grog@lemis.com) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 04C996ACC0; Tue, 5 Jun 2001 07:49:30 +0930 (CST) Date: Tue, 5 Jun 2001 07:49:29 +0930 From: Greg Lehey To: John Baldwin Cc: Yar Tikhiy , freebsd-arch@FreeBSD.org, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_gif.c Message-ID: <20010605074929.V99950@wantadilla.lemis.com> References: <20010604094503.A43248@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from jhb@FreeBSD.org on Mon, Jun 04, 2001 at 11:10:03AM -0700 Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Monday, 4 June 2001 at 11:10:03 -0700, John Baldwin wrote: > > On 04-Jun-01 Yar Tikhiy wrote: >> [Added freebsd-arch to the Cc: list] >> >> On Mon, Jun 04, 2001 at 09:48:27AM +0930, Greg Lehey wrote: >>> On Sunday, 3 June 2001 at 10:31:11 -0700, Yar Tikhiy wrote: >>>> yar 2001/06/03 10:31:11 PDT >>>> >>>> Modified files: >>>> sys/net if_gif.c >>>> Log: >>>> First, wrap the if_up() call into splimp()/splx() because >>>> if_up() must be called at splnet or higher. >>>> Second, set the IFF_RUNNING flag on an interface after its >>>> resources (i.e. tunnel source and destination addresses) >>>> have been set. Note that we don't set IFF_UP because it is >>>> if_up()'s job to do that. >>> >>> Presumably this is in preparation for an MFC? splimp() and splx() are >>> nops in -CURRENT. >> >> Thank you for pointing me out that. Indeed, I've missed the change. >> >> BTW, could anyone tell me what is the modern state of affairs as >> to locks in the networking code? The comments and man pages are >> still talking about splnet in -current, so they need to be fixed, >> but what should one write there instead? The IF_ENQUEUE case is >> obvious: Forget about splnet() and the manual modification of >> counters, just use IF_HANDOFF instead of IF_ENQUEUE. But what about >> other places where splnet/splimp is used? There are quite a few of >> them there... > > The networking stack is not locked with locks yet, so just use spl's > for now. Why? They still don't do anything. Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message