From owner-freebsd-mobile@freebsd.org Mon Oct 3 22:05:09 2016 Return-Path: Delivered-To: freebsd-mobile@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D3F91AF353F; Mon, 3 Oct 2016 22:05:09 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id C6009853; Mon, 3 Oct 2016 22:05:07 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id BAA29095; Tue, 04 Oct 2016 01:05:06 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1brBMA-0006AI-7u; Tue, 04 Oct 2016 01:05:06 +0300 Subject: Re: [request for testing] isl, cyapa on chromebooks To: Michael Gmelin References: <1e66fc64-cdff-e94b-4b0c-55cb05e2b5a1@FreeBSD.org> <20161003180750.744dae0a@bsd64.grem.de> <20161003222528.56d46787@bsd64.grem.de> Cc: FreeBSD Current , freebsd-mobile@FreeBSD.org From: Andriy Gapon Message-ID: Date: Tue, 4 Oct 2016 01:04:10 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161003222528.56d46787@bsd64.grem.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-mobile@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Mobile computing with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Oct 2016 22:05:09 -0000 On 03/10/2016 23:25, Michael Gmelin wrote: > On Mon, 3 Oct 2016 19:41:17 +0300 > Andriy Gapon wrote: > >> On 03/10/2016 19:07, Michael Gmelin wrote: >>> I upgraded the latter the r306641, applied your patches (cleanly) >>> and ran "make kernel" (GENERIC kernel), added the entries to >>> device.hints and rebooted. Unfortunately ig4 won't load: >>> >>> # kldload ig4 >>> link_elf_obj: symbol iicbus_transfer_desc undefined >>> linker_load_file: Unsupported file type >> >> Hmm, seems like forgot to declare the iicbus module dependency. >> Could you please kldload iicbus and see if that helps? >> Meanwhile I'll add the dependency. > > Unfortunately this doesn't help, you should be able to reproduce it > yourself without access to the actual hardware though. > > I worked around this by adding the iicbus dependency to ig4_pci.c (and > also to "files"). Okay, this should be in the latest patch anyway. > Now loading ig4 works and both lynx point controllers are detected. > Loading isl doesn't create any output and doesn't seem to detect any > devices. Also, devinfo shows both controllers (ig4iic0, ig4iic1), but > no iicbus devices. > > # devinfo | grep iic > ig4iic0 > ig4iic1 Is there anything interesting from from ig4 in the log / dmesg? Could you please check that your copy of the patch contains this chunk? @@ -549,7 +780,7 @@ ig4iic_attach(ig4iic_softc_t *sc) IG4_CTL_RESTARTEN | IG4_CTL_SPEED_STD); - sc->smb = device_add_child(sc->dev, "smbus", -1); + sc->smb = device_add_child(sc->dev, "iicbus", -1); if (sc->smb == NULL) { device_printf(sc->dev, "smbus driver not found\n"); error = ENXIO; -- Andriy Gapon