From owner-freebsd-java@FreeBSD.ORG  Wed Sep  3 06:29:23 2003
Return-Path: <owner-freebsd-java@FreeBSD.ORG>
Delivered-To: freebsd-java@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1AEB116A4BF
	for <freebsd-java@freebsd.org>; Wed,  3 Sep 2003 06:29:23 -0700 (PDT)
Received: from smtp1.euronet.nl (smtp1.euronet.nl [194.134.35.133])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BD79743FE9
	for <freebsd-java@freebsd.org>; Wed,  3 Sep 2003 06:29:21 -0700 (PDT)
	(envelope-from ernst.dehaan@nl.wanadoo.com)
Received: from zaphod.euronet.nl (zaphod.euronet.nl [194.134.168.213])
	by smtp1.euronet.nl (Postfix) with ESMTP
	id 30F336751B; Wed,  3 Sep 2003 15:29:19 +0200 (MEST)
From: Ernst de Haan <ernst.dehaan@nl.wanadoo.com>
Organization: Wanadoo Nederland B.V.
To: Jun Kuriyama <kuriyama@imgsrc.co.jp>,
	Greg Lewis <glewis@misty.eyesbeyond.com>
Date: Wed, 3 Sep 2003 15:29:21 +0200
User-Agent: KMail/1.5.2
References: <20030826143510.GB31392@misty.eyesbeyond.com>
	<20030826163429.GA41436@misty.eyesbeyond.com>
	<7misoaknwu.wl@black.imgsrc.co.jp>
In-Reply-To: <7misoaknwu.wl@black.imgsrc.co.jp>
X-Address: Muiderstraat 1, Amsterdam, Netherlands
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200309031529.21868.ernst.dehaan@nl.wanadoo.com>
cc: freebsd-java@freebsd.org
Subject: Re: Binary release via ports
X-BeenThere: freebsd-java@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting Java to FreeBSD <freebsd-java.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
	<mailto:freebsd-java-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-java>
List-Post: <mailto:freebsd-java@freebsd.org>
List-Help: <mailto:freebsd-java-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
	<mailto:freebsd-java-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Sep 2003 13:29:23 -0000

On the sight of it, the patch looked good. I haven't had time to test it 
myself though.

Greg, you can commit this if you like, you have my full approval :-)

Ernst

On woensdag 3 september 2003 15:21, Jun Kuriyama wrote:
> At Tue, 26 Aug 2003 16:26:21 +0000 (UTC),
>
> Greg Lewis wrote:
> > Correct.  See attached patch which I've been meaning to send to Ernst
> > for review since yesterday.  I think it does the right thing.
>
> Any news about this?  I think this patch should be included in 4.9.
>
> > @@ -204,7 +212,8 @@
> >  .		if (${USE_JAVA} == "1.1+")
> >  .			if defined(HAVE_JAVA_FREEBSD_1_4)
> >  USE_JAVA=	1.4
> > -.			elif defined(HAVE_JAVA_FREEBSD_1_3) || \
> > +.			elif defined(HAVE_JAVA_DIABLO_FREEBSD_1_3) || \
> > +			   defined(HAVE_JAVA_FREEBSD_1_3)
> >  			   defined(HAVE_JAVA_SUN_LINUX_1_3) || \
> >  			   defined(HAVE_JAVA_BLACKDOWN_LINUX_1_3) || \
> >  			   defined(HAVE_JAVA_IBM_LINUX_1_3)
>
> " || \" is missing in this chunk.