From owner-freebsd-current@FreeBSD.ORG Tue Aug 16 13:06:48 2005 Return-Path: X-Original-To: current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2FC3516A41F; Tue, 16 Aug 2005 13:06:48 +0000 (GMT) (envelope-from gallatin@cs.duke.edu) Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id E1BF543D5D; Tue, 16 Aug 2005 13:06:41 +0000 (GMT) (envelope-from gallatin@cs.duke.edu) Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30]) by duke.cs.duke.edu (8.13.4/8.13.4) with ESMTP id j7GD6eTs003626 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 16 Aug 2005 09:06:40 -0400 (EDT) Received: (from gallatin@localhost) by grasshopper.cs.duke.edu (8.12.9p2/8.12.9/Submit) id j7GD6VeO008804; Tue, 16 Aug 2005 09:06:31 -0400 (EDT) (envelope-from gallatin) From: Andrew Gallatin MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17153.58583.84605.272007@grasshopper.cs.duke.edu> Date: Tue, 16 Aug 2005 09:06:31 -0400 (EDT) To: Antoine Brodin In-Reply-To: <20050813113333.592c999b.antoine.brodin@laposte.net> References: <20050813004326.GA47855@xor.obsecurity.org> <20050813005233.GA48108@xor.obsecurity.org> <20050813113333.592c999b.antoine.brodin@laposte.net> X-Mailer: VM 6.75 under 21.1 (patch 12) "Channel Islands" XEmacs Lucid Cc: current@FreeBSD.org, phk@FreeBSD.org, Kris Kennaway Subject: Re: Infinite loop in devfs_create() X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2005 13:06:48 -0000 Antoine Brodin writes: > Kris Kennaway wrote: > > On Fri, Aug 12, 2005 at 08:43:26PM -0400, Kris Kennaway wrote: > > > I have an SMP amd64 package machine that has deadlocked, apparently > > > here: > > This could explain some mysterious deadlocks I've been getting on > > sparc machines too, which also cycle through md devices in a similar > > way. I bet something is not being cleaned up properly when the > > devices are unconfigured, and eventually devfs is filling up all > > available inodes (1024) and failing gracelessly. > > I'm not sure but this may be related to PR: kern/81588 I mentioned the same suspicious indentation in revision 1.172 of kern/kern_conf.c to phk back in April. He told me then: Hmm, that looks like an indentation bug, it is all part of the condition for being able to release it at that time. Speaking of devfs problems along these lines, it used to be that a simple shell script which opened a cloning device could be used to DOS a FreeBSD 6.0 box, since the device cloning code doesn't reap unused clones. ( kldload nmdm; while true; do touch /dev/nmdm; done). It looks like your patch is intended to fix the problem.. I hope phk looks at it.. Drew