From owner-freebsd-current@FreeBSD.ORG  Wed Oct 22 08:03:28 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 068A1106566C
	for <current@freebsd.org>; Wed, 22 Oct 2008 08:03:28 +0000 (UTC)
	(envelope-from ed@hoeg.nl)
Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:7b8:3fb::211])
	by mx1.freebsd.org (Postfix) with ESMTP id C029A8FC1A
	for <current@freebsd.org>; Wed, 22 Oct 2008 08:03:27 +0000 (UTC)
	(envelope-from ed@hoeg.nl)
Received: by palm.hoeg.nl (Postfix, from userid 1000)
	id 06D791CD19; Wed, 22 Oct 2008 10:03:27 +0200 (CEST)
Date: Wed, 22 Oct 2008 10:03:26 +0200
From: Ed Schouten <ed@80386.nl>
To: current@freebsd.org
Message-ID: <20081022080326.GH16837@hoeg.nl>
References: <20081021210023.0CE4373039@freebsd-current.sentex.ca>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="kIf/M4+cOKmnPkRL"
Content-Disposition: inline
In-Reply-To: <20081021210023.0CE4373039@freebsd-current.sentex.ca>
User-Agent: Mutt/1.5.18 (2008-05-17)
Cc: 
Subject: Re: [head tinderbox] failure on i386/i386
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Oct 2008 08:03:28 -0000


--kIf/M4+cOKmnPkRL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* FreeBSD Tinderbox <tinderbox@freebsd.org> wrote:
> cc1: warnings being treated as errors
> /src/sys/dev/ppbus/lpt.c: In function 'lpt_attach':
> /src/sys/dev/ppbus/lpt.c:402: warning: assignment makes pointer from inte=
ger without a cast
> /src/sys/dev/ppbus/lpt.c: In function 'lptopen':
> /src/sys/dev/ppbus/lpt.c:479: warning: assignment makes integer from poin=
ter without a cast

What about this?

%%%
--- sys/dev/ppbus/lpt.c
+++ sys/dev/ppbus/lpt.c
@@ -392,14 +392,12 @@
 	lpt_release_ppbus(dev);
=20
 	sc->dev =3D dev;
-	sc->cdev =3D make_dev(&lpt_cdevsw, unit,
+	sc->cdev =3D make_dev(&lpt_cdevsw, 0,
 	    UID_ROOT, GID_WHEEL, 0600, LPT_NAME "%d", unit);
 	sc->cdev->si_drv1 =3D sc;
-	sc->cdev->si_drv2 =3D 0;
-	sc->cdev_bypass =3D make_dev(&lpt_cdevsw, unit,
+	sc->cdev_bypass =3D make_dev(&lpt_cdevsw, LP_BYPASS,
 	    UID_ROOT, GID_WHEEL, 0600, LPT_NAME "%d.ctl", unit);
 	sc->cdev_bypass->si_drv1 =3D sc;
-	sc->cdev_bypass->si_drv2 =3D LP_BYPASS;
 	return (0);
 }
=20
@@ -476,7 +474,7 @@
 	} else
 		sc->sc_state |=3D LPTINIT;
=20
-	sc->sc_flags =3D dev->si_drv2;
+	sc->sc_flags =3D dev2unit(dev);
=20
 	/* Check for open with BYPASS flag set. */
 	if (sc->sc_flags & LP_BYPASS) {
%%%

--=20
 Ed Schouten <ed@80386.nl>
 WWW: http://80386.nl/

--kIf/M4+cOKmnPkRL
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)

iEYEARECAAYFAkj+3k4ACgkQ52SDGA2eCwU42wCeNBJIEqHybsrX0mKoeQ9/ygRF
kVYAnRPo4cGRdo3gHXUQlxqcxc+s3DS1
=VmKF
-----END PGP SIGNATURE-----

--kIf/M4+cOKmnPkRL--