Date: Sat, 21 Jan 2017 22:10:43 +0000 (UTC) From: "Tobias C. Berner" <tcberner@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r432089 - in head/graphics/py-poppler-qt4: . files Message-ID: <201701212210.v0LMAhsv059765@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: tcberner Date: Sat Jan 21 22:10:43 2017 New Revision: 432089 URL: https://svnweb.freebsd.org/changeset/ports/432089 Log: Fix graphics/py-poppler-qt4: fails to build with clang 4.0 PyList_SET_ITEM() is supposed to be void, but as a macro it's an expression and has a pointer value. Clang 4.0 trips on the bogus pointer comparison; given the comparison, it should be PyList_SetItem() which returns -1 on failure. PR: 216228 Approved by: portmgr blanket, rakuco (mentor) MFH: 2017Q1 Added: head/graphics/py-poppler-qt4/files/ head/graphics/py-poppler-qt4/files/patch-types.sip (contents, props changed) Modified: head/graphics/py-poppler-qt4/Makefile Modified: head/graphics/py-poppler-qt4/Makefile ============================================================================== --- head/graphics/py-poppler-qt4/Makefile Sat Jan 21 22:08:06 2017 (r432088) +++ head/graphics/py-poppler-qt4/Makefile Sat Jan 21 22:10:43 2017 (r432089) @@ -2,7 +2,7 @@ PORTNAME= poppler-qt4 PORTVERSION= 0.18.1 -PORTREVISION= 7 +PORTREVISION= 8 CATEGORIES= graphics python MASTER_SITES= CHEESESHOP PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} Added: head/graphics/py-poppler-qt4/files/patch-types.sip ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/graphics/py-poppler-qt4/files/patch-types.sip Sat Jan 21 22:10:43 2017 (r432089) @@ -0,0 +1,16 @@ +PyList_SET_ITEM() is supposed to be void, but as a macro it's an +expression and has a pointer value. Clang 4.0 trips on the bogus +pointer comparison; given the comparison, it should be PyList_SetItem() +which returns -1 on failure. + +--- types.sip.orig 2017-01-21 07:19:29 UTC ++++ types.sip +@@ -27,7 +27,7 @@ + foreach (Poppler::Document::RenderBackend value, set) + { + PyObject *obj = PyLong_FromLong ((long) value); +- if (obj == NULL || PyList_SET_ITEM (l, i, obj) < 0) ++ if (obj == NULL || PyList_SetItem (l, i, obj) < 0) + { + Py_DECREF(l); +
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201701212210.v0LMAhsv059765>