Date: Fri, 18 Oct 2013 11:42:07 +0200 From: Baptiste Daroussin <bapt@freebsd.org> To: Oliver Lehmann <oliver@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, marino@freebsd.org, John Marino <freebsd.contact@marino.st>, ports-committers@freebsd.org Subject: Re: svn commit: r330725 - in head/games/heretic: . files Message-ID: <20131018094206.GJ42657@ithaqua.etoilebsd.net> In-Reply-To: <20131018102511.Horde.6_u53MDsMxrI1SPe8hTA5Q3@avocado.salatschuessel.net> References: <201310180705.r9I75eZV063407@svn.freebsd.org> <20131018075408.GI42657@ithaqua.etoilebsd.net> <20131018095930.Horde.738PZNGCU9PTyyjPK3vb3g1@avocado.salatschuessel.net> <5260ECEB.70302@marino.st> <20131018102511.Horde.6_u53MDsMxrI1SPe8hTA5Q3@avocado.salatschuessel.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--JsihDCElWRmQcbOr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 18, 2013 at 10:25:11AM +0200, Oliver Lehmann wrote: >=20 > John Marino <freebsd.contact@marino.st> wrote: >=20 > > Oliver, > > As I understand it, the original line only defines CC to "gcc" if CC is > > not present in the MAKE_ARGS. Thus bapt is correct, you don't need to > > patch this line. > > > > (In BSD make, it would be CC?=3Dgcc, but gmake looks at MAKE_ARGS) >=20 > Oups... I was under the impression it uses bmake but it uses indeed > GNU make. I'll recheck it and probably remove the patch. fmake, gmake and bmake works the same in that area. IIRC that is a POSIX make behaviour. Basically: Make first take the macros defined in arguments, then the one defined in the Makefile themself which cannot overwrite the first, then fallback on env wh= ich cannot overwrite the 2 previous. regards, Bapt --JsihDCElWRmQcbOr Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlJhAm4ACgkQ8kTtMUmk6EwMKgCggEdCtgQmyBCKAGS9oftQdkN0 U80AoJ2v0q8+DfMEAUXZfy7YKo4iUnZi =/Yyk -----END PGP SIGNATURE----- --JsihDCElWRmQcbOr--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131018094206.GJ42657>