From owner-svn-src-head@freebsd.org  Sun Jul  8 22:45:22 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3174B103E9F1;
 Sun,  8 Jul 2018 22:45:22 +0000 (UTC)
 (envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
 by mx1.freebsd.org (Postfix) with ESMTP id BFE3070723;
 Sun,  8 Jul 2018 22:45:21 +0000 (UTC)
 (envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (unknown [192.168.55.3])
 by phk.freebsd.dk (Postfix) with ESMTP id 191FD14813;
 Sun,  8 Jul 2018 22:45:15 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
 by critter.freebsd.dk (8.15.2/8.15.2) with ESMTPS id w68MjETa038041
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Sun, 8 Jul 2018 22:45:14 GMT (envelope-from phk@critter.freebsd.dk)
Received: (from phk@localhost)
 by critter.freebsd.dk (8.15.2/8.15.2/Submit) id w68MjE2F038040;
 Sun, 8 Jul 2018 22:45:14 GMT (envelope-from phk)
To: "Pedro F. Giffuni" <pfg@FreeBSD.org>
cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r336113 - head/usr.bin/gzip
In-reply-to: <201807082239.w68MdXwD053621@repo.freebsd.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
References: <201807082239.w68MdXwD053621@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <38038.1531089914.1@critter.freebsd.dk>
Content-Transfer-Encoding: quoted-printable
Date: Sun, 08 Jul 2018 22:45:14 +0000
Message-ID: <38039.1531089914@critter.freebsd.dk>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Jul 2018 22:45:22 -0000

--------
In message <201807082239.w68MdXwD053621@repo.freebsd.org>, "Pedro F. Giffu=
ni" writes:

>  New version:
>  =

>      usize =3D buf[4];
>      usize |=3D (unsigned int)buf[5] << 8;
>      usize |=3D (unsigned int)buf[6] << 16;
>      usize |=3D (unsigned int)buf[7] << 24;

Why not use the functions in endian.h ?

-- =

Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    =

Never attribute to malice what can adequately be explained by incompetence=
.