From owner-cvs-all@FreeBSD.ORG Mon Apr 26 18:27:06 2010 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 74154106566C for ; Mon, 26 Apr 2010 18:27:06 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx23.fluidhosting.com [204.14.89.6]) by mx1.freebsd.org (Postfix) with ESMTP id 24AA58FC18 for ; Mon, 26 Apr 2010 18:27:05 +0000 (UTC) Received: (qmail 31637 invoked by uid 399); 26 Apr 2010 18:23:38 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 26 Apr 2010 18:23:38 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4BD5DA27.8050806@FreeBSD.org> Date: Mon, 26 Apr 2010 11:23:35 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.9) Gecko/20100330 Thunderbird/3.0.4 MIME-Version: 1.0 To: Jun Kuriyama References: <201004261339.o3QDdm8V026827@repoman.freebsd.org> In-Reply-To: <201004261339.o3QDdm8V026827@repoman.freebsd.org> X-Enigmail-Version: 1.0.1 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/databases/kumofs Makefile distinfo pkg-plist ports/databases/kumofs/files kumofs-gateway.sh.in kumofs-manager.sh.in kumofs-server.sh.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Apr 2010 18:27:06 -0000 There are numerous problems with these scripts. The first and most important is that you apparently didn't test them with an up to date ports tree because %%RC_SUBR%% is no longer expanded. You also need to read http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html for details on the following: 1. New scripts should not be added with the .sh extension 2. Scripts that run as a specific user must REQUIRE: LOGIN 3. Default variable assignments should use =, not := 4. There should not be default assignments to empty variables, they should be documented in the comments. 5. Since you're adding these all in the same port, it would be better (although not mandatory) if you used REQUIRE instead of BEFORE. That makes debugging easier. Please correct these (especially the %%RC_SUBR%% issue) ASAP and bump PORTREVISION. Thanks, Doug On 04/26/10 06:39, Jun Kuriyama wrote: > kuriyama 2010-04-26 13:39:48 UTC > > FreeBSD ports repository > > Modified files: > databases/kumofs Makefile distinfo pkg-plist > Added files: > databases/kumofs/files kumofs-gateway.sh.in > kumofs-manager.sh.in > kumofs-server.sh.in > Log: > - Upgrade to 0.3.4. > > Revision Changes Path > 1.4 +16 -6 ports/databases/kumofs/Makefile > 1.3 +3 -3 ports/databases/kumofs/distinfo > 1.1 +29 -0 ports/databases/kumofs/files/kumofs-gateway.sh.in (new) > 1.1 +29 -0 ports/databases/kumofs/files/kumofs-manager.sh.in (new) > 1.1 +31 -0 ports/databases/kumofs/files/kumofs-server.sh.in (new) > 1.2 +4 -0 ports/databases/kumofs/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/kumofs/Makefile.diff?&r1=1.3&r2=1.4&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/kumofs/distinfo.diff?&r1=1.2&r2=1.3&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/kumofs/files/kumofs-gateway.sh.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/kumofs/files/kumofs-manager.sh.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/kumofs/files/kumofs-server.sh.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/kumofs/pkg-plist.diff?&r1=1.1&r2=1.2&f=h > -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/