From owner-svn-src-all@freebsd.org Wed Aug 26 19:23:04 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DFA653B9206 for ; Wed, 26 Aug 2020 19:23:04 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BcG3X0nV1z4WMF for ; Wed, 26 Aug 2020 19:23:03 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f67.google.com with SMTP id r15so2949044wrp.13 for ; Wed, 26 Aug 2020 12:23:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=wju96yoU8bHVs59ytpClBdsnHIvncRhlFZixUsEVb08=; b=o28v/3Jl4tTGWx4QmZtm8EeiBX8rxpxWijW8vBAlrrSF260xjlGf50Gipjz2onpxir +UScDhZpvwJWj0SlKr0vGaI4M9F46KUnOnQf5fYa6CCWNPR1XKsIKfIMOaJYHSR+r8sh voh3tFjCbyZ4MKdlPYELjpI5niRdw7yGVi8KDbBBQS8RpH9N/Lag7k8/WFU70dXOl3ps fxrYvbL7eQBkusea2IejhLJUc4eUAe7Qt9mhvtRkq0bk+gntvKcj+5iAXmHHNFhGwO1v TpkuXqUN/3J2Xi82AWyBYljlz8tiwRG+R/YKJI4Yv+PfL4SqWbOkztPxAi+Dn7XCL5va LGfw== X-Gm-Message-State: AOAM5332bUSv2W5DbhRT1gk4d4qbHW6dR4kNHVyhdUfUVkqtykITaoDV D/kgnikaGJk1lNIx3w5DRX/KAA== X-Google-Smtp-Source: ABdhPJwJPNZMim0YE2KFEU+nR4yifbN7zn3FSyea4cIHKLcYCB6bGypp6KXa4SwU0RoiPwigjXXdAA== X-Received: by 2002:a5d:410e:: with SMTP id l14mr16502646wrp.216.1598469782707; Wed, 26 Aug 2020 12:23:02 -0700 (PDT) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id d66sm8616450wmc.16.2020.08.26.12.23.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Aug 2020 12:23:02 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: svn commit: r364799 - in head: share/man/man9 sys/crypto/ccp sys/dev/cxgbe/crypto sys/dev/sec sys/kern sys/opencrypto From: Jessica Clarke In-Reply-To: Date: Wed, 26 Aug 2020 20:23:01 +0100 Cc: Alan Somers , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <202008260237.07Q2bhwF045988@repo.freebsd.org> <7e0abc1a-a397-46c3-b283-2c1ab21a9c4d@www.fastmail.com> <2534D2E5-2974-4067-8B9C-53EE3E8C6A68@freebsd.org> To: Brandon Bergren X-Mailer: Apple Mail (2.3608.120.23.2.1) X-Rspamd-Queue-Id: 4BcG3X0nV1z4WMF X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.221.67 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com X-Spamd-Result: default: False [-1.31 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MID_RHS_MATCH_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.88)[-0.881]; FREEFALL_USER(0.00)[jrtc27]; FROM_HAS_DN(0.00)[]; NEURAL_SPAM_SHORT(0.00)[0.005]; NEURAL_HAM_LONG(-0.94)[-0.938]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.221.67:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.221.67:from]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[svn-src-all] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2020 19:23:04 -0000 On 26 Aug 2020, at 20:21, Brandon Bergren wrote: > On Wed, Aug 26, 2020, at 2:19 PM, Jessica Clarke wrote: >> On 26 Aug 2020, at 20:16, Brandon Bergren wrote: >>> On Tue, Aug 25, 2020, at 9:37 PM, Alan Somers wrote: >>>> Author: asomers >>>> Date: Wed Aug 26 02:37:42 2020 >>>> New Revision: 364799 >>>> URL: https://svnweb.freebsd.org/changeset/base/364799 >>>>=20 >>>> Modified: head/sys/dev/sec/sec.c >>>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>>> --- head/sys/dev/sec/sec.c Wed Aug 26 02:13:27 2020 = (r364798) >>>> +++ head/sys/dev/sec/sec.c Wed Aug 26 02:37:42 2020 = (r364799) >>>> @@ -851,6 +851,9 @@ sec_desc_map_dma(struct sec_softc *sc, struct = sec_dma_ >>>> case CRYPTO_BUF_MBUF: >>>> size =3D m_length(crp->crp_buf.cb_mbuf, NULL); >>>> break; >>>> + case CRYPTO_BUF_VMPAGE: >>>> + size =3D PAGE_SIZE - cb->cb_vm_page_offset; >>>> + break; >>>> default: >>>> return (EINVAL); >>>> } >>>=20 >>> Uh, where is cb coming from? Shouldn't this be using = crp->crp_buf.cb_vm_page_offset? This is causing a build failure on = powerpc and powerpcspe. I don't see why other platforms aren't also = erroring out here. >>=20 >> Because it's PowerPC-specific: >>=20 >> sys/conf/files.powerpc:dev/sec/sec.c optional sec mpc85xx >>=20 >> Jess >>=20 >>=20 >=20 > No, I mean literally. What scope is cb coming from? It's not a = variable that is in scope for that function as far as I can tell. Oh no I agree it's wrong and your proposal sounds correct. I was just explaining why it's only noticed in PowerPC builds. Jess