Date: Tue, 26 Oct 2004 16:56:16 -0400 From: John Baldwin <jhb@freebsd.org> To: Peter Wemm <peter@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 63626 for review Message-ID: <200410261656.16293.jhb@FreeBSD.org> In-Reply-To: <200410240635.i9O6ZtSs069953@repoman.freebsd.org> References: <200410240635.i9O6ZtSs069953@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday 24 October 2004 02:35 am, Peter Wemm wrote: > http://perforce.freebsd.org/chv.cgi?CH=63626 > > Change 63626 by peter@peter_overcee on 2004/10/24 06:35:44 > > bind to cpu 0 on for shutting down. It saves a whole bunch of > complications later on. > > Affected files ... > > .. //depot/projects/hammer/sys/kern/kern_shutdown.c#27 edit > > Differences ... > > ==== //depot/projects/hammer/sys/kern/kern_shutdown.c#27 (text+ko) ==== > > @@ -246,6 +246,9 @@ > { > static int first_buf_printf = 1; > > + /* Do all shutdown processing on cpu0 */ > + sched_bind(curthread, 0); > + > /* collect extra flags that shutdown_nice might have set */ > howto |= shutdown_howto; This should really be s/0/boot_cpuid/ (or boot_cpu_id) but that variable first needs to be fixed to reflect PCPU_GET(cpuid) on all archs (on x86 it is the local APIC ID IIRC). -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200410261656.16293.jhb>