From owner-svn-src-all@freebsd.org Thu Oct 13 21:02:45 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B7062C10623; Thu, 13 Oct 2016 21:02:45 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pa0-x229.google.com (mail-pa0-x229.google.com [IPv6:2607:f8b0:400e:c03::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 864D7EAB; Thu, 13 Oct 2016 21:02:45 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pa0-x229.google.com with SMTP id qn10so41316558pac.2; Thu, 13 Oct 2016 14:02:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ucBigxgbI5wM/r2MEsptF6mwUMQzHQcPi892P84Ydwk=; b=0xmnyfx02fKuy7hUfuFiFC8yEzxAbsnMIFGmfVo5cCH1RT2ZVWic4lPwg/SNAlY17N o6Vly/Xl9GuHH9odXVuVLKPZ3NzbqVhhX2tcV8g2efFLKyirLmp+7d1jLnVKgJF8q1B9 vDVFYLurP+COkk1HPF+igeVSMW2VSXQTxy2FGgVCnFzgxuik4XiRVRX4ZhDEfqM46ezz zAtoLxY46w8wp64FyOeFMnuz7dIyLiNc4pna4bpgILJV7v7De1+NAjbxpZNyC7CzjPSN TuZZOiMsbvffk2IGO0Sue0170mNIie1E4SWvH0Lk+dRT2qgA3TIulvvNAcjCyDWfLQX+ eenA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=ucBigxgbI5wM/r2MEsptF6mwUMQzHQcPi892P84Ydwk=; b=EAZvO2lye3RyRXHTdJj419CyxcC8urPF3TkzN1PvF+2rw0Dqbezy80JdgUIdYoXww3 nKINcb2WykfbwJXPvyCEEYIuu1XISKWb1CBh8fMsoRy8BLLGylOEHoAypa4792O+wUTx OeNE73Mk0/PCEgP23YXa/NgU5isaSrtELPjyTBwTAjwhhAo9h8iFCGVpTd1lsWpKW9wh Hfj9EA9RBPQrG4j6Npf1XjSZReCw+qt3yYuxX9U/vNE3if073UCShsieWIgiGNXYZXhj m1i+ZvAVYBpY6lnzoCQJHUZhbQV26rYPgIy00yr9MTl0kD25aBGLuiPuQiX3qvXE1hxM hALQ== X-Gm-Message-State: AA6/9Rl5B102hKVkH7h3SzT/mgXZhbaWcWtu4n1UXCZtR2cVpm/H/s005+6i3UTrF+8huQ== X-Received: by 10.66.254.10 with SMTP id ae10mr10824834pad.26.1476392564888; Thu, 13 Oct 2016 14:02:44 -0700 (PDT) Received: from wkstn-mjohnston.west.isilon.com (c-76-104-201-218.hsd1.wa.comcast.net. [76.104.201.218]) by smtp.gmail.com with ESMTPSA id 3sm21767567pfo.31.2016.10.13.14.02.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Oct 2016 14:02:44 -0700 (PDT) Sender: Mark Johnston Date: Thu, 13 Oct 2016 14:08:41 -0700 From: Mark Johnston To: Conrad Meyer Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r307236 - head/sys/vm Message-ID: <20161013210841.GB52539@wkstn-mjohnston.west.isilon.com> References: <201610132039.u9DKdY0u016480@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Oct 2016 21:02:45 -0000 On Thu, Oct 13, 2016 at 01:49:29PM -0700, Conrad Meyer wrote: > On Thu, Oct 13, 2016 at 1:39 PM, Mark Johnston wrote: > > Author: markj > > Date: Thu Oct 13 20:39:34 2016 > > New Revision: 307236 > > URL: https://svnweb.freebsd.org/changeset/base/307236 > > > > Log: > > Plug a potential vnode lock leak in vm_fault_hold(). > > This isn't just potential, right? I believe we hit this one > empirically with an assert in place of this if/vput. Sorry, right, that was bad wording. I meant that the lock is not always leaked in this error path - the map lookup needs to succeed initially, after which we need to block for the vnode lock, restart the fault handler, and then get an error from vm_map_lookup(). If the initial lookup fails, there's no leak.