From owner-freebsd-testing@FreeBSD.ORG Tue Oct 15 16:21:07 2013 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 1C20AD33 for ; Tue, 15 Oct 2013 16:21:07 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x235.google.com (mail-pa0-x235.google.com [IPv6:2607:f8b0:400e:c03::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E7E5A23F4 for ; Tue, 15 Oct 2013 16:21:06 +0000 (UTC) Received: by mail-pa0-f53.google.com with SMTP id kq14so9222686pab.40 for ; Tue, 15 Oct 2013 09:21:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:mime-version:in-reply-to:content-type :content-transfer-encoding:message-id:cc:from:subject:date:to; bh=JL5P6IUzLvJeZgagRvM2T5p3ukOBSKbPTdpL83I+TeY=; b=CzdkN9qGwUevBFD2/Uz6T8EEyd62AcutwXFiYXP6qRu2FxWFddvUdoY/ewLroR87HJ DNNV3yiR+XahRs3DgPTuKpd3GdwT26cSmjrkPzTaRJBTduCI0SlfVrgqVOgfLwT8beiS jIN/jTGNfm7RttLhBUnxjbFwzG/0BIWBcK+Aoq2WHs8IHXTX0ItRngWxDonBtYqkc/Lk jozHz7epYJgw9JI7+3oLzFrp8gy6PSdRBi3lf0185Moda3kSPlcyWHJTor3VAkd6mI2j uN1Z9je4Lm0cVCdpPmWfE9iZeMnzuCEGk/HcCn6D6RKuUkBeAPLZ1ceTUv4l1HYkv3Qu qwGw== X-Received: by 10.68.172.36 with SMTP id az4mr42929363pbc.48.1381854065966; Tue, 15 Oct 2013 09:21:05 -0700 (PDT) Received: from [10.0.1.114] ([64.14.143.130]) by mx.google.com with ESMTPSA id hz10sm85502523pbc.36.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 15 Oct 2013 09:21:04 -0700 (PDT) References: Mime-Version: 1.0 (1.0) In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <0017182B-9793-4A39-BC3F-7FF684AA1224@gmail.com> X-Mailer: iPhone Mail (11A501) From: Garrett Cooper Subject: Re: Refactoring of *.test.mk Date: Tue, 15 Oct 2013 09:21:03 -0700 To: Julio Merino Cc: "freebsd-testing@freebsd.org" , Rui Paulo , Simon Gerraty X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Oct 2013 16:21:07 -0000 > On Oct 14, 2013, at 20:24, Julio Merino wrote: > > [Fixing Garrett's address...] > >> On Mon, Oct 14, 2013 at 10:44 PM, Julio Merino wrote: >> Hello all, >> >> [ CCing a few people directly that are probably interested. ] >> >> After the recent removal of the deprecated ATF tools from the tree, I >> have been working on a refactoring of the FreeBSD *.test.mk Makefiles >> to add various features that spilled from that change. >> >> The highlights of this work so far: >> >> - Clearly documented the interface of each *.test.mk file by putting >> the list of public variables at the top and adding comments where due. >> >> - Split the logic to build framework-less test programs into a new >> plain.test.mk file. This is in accordance with atf.test.mk, but also >> helps clarifying the code, defining a proper interfac in bsd.test.mk >> and makes some of the other changes simpler. >> >> - Added support to generate both Atffile and Kyuafile files. >> >> - Added support to run the tests using both atf-run and kyua (from ports). >> >> You can find the relevant patches in: >> http://portal.meroh.net/~jmmv/freebsd-testing/ . >> >> The patches have been generated using quilt so take a look at the >> contents of the 'series' file to see in which order they would need to >> be applied. >> >> Each patch has a description at the top which can later be used as the >> commit log. >> >> Note that, at the moment, this can only be exercised in >> lib/libcrypt/tests/ . I actually wanted to write some tests for >> *.test.mk themselves (!) but I wouldn't want to spend time on that >> before agreeing that this structure is sensible. If it is, I might put >> the effort ;-) See the ones here >> http://cvsweb.netbsd.org/bsdweb.cgi/src/tests/share/mk/?only_with_tag=MAIN >> to get an idea of what they could look like. >> >> Anybody up for reviewing these patches and sharing their comments? >> >> Thanks! >> >> -- >> Julio Merino / @jmmv > > > > -- > Julio Merino / @jmmv