From owner-freebsd-stable@FreeBSD.ORG Fri Nov 28 11:35:07 2014 Return-Path: Delivered-To: stable@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 721D5E1B for ; Fri, 28 Nov 2014 11:35:07 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5B001AE1 for ; Fri, 28 Nov 2014 11:35:07 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id sASBZ72G035206 for ; Fri, 28 Nov 2014 11:35:07 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: stable@FreeBSD.org Subject: [Bug 193367] [panic] sleeping thread Date: Fri, 28 Nov 2014 11:35:07 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 9.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Nov 2014 11:35:07 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D193367 --- Comment #14 from Konstantin Belousov --- (In reply to Eygene Ryabinkin from comment #13) > Perhaps the more proper thing will be to say > .max_ioctl =3D (DRM_ARRAY_SIZE(i915_ioctls) - 1) > since this will preserve the semantics of the "max_ioctl" name that should > keep the index of the last ioctl and not the number of driver-specific > ioctls. >=20 > I'd go this route, though the change will be slightly more intrusive; nam= ely > http://codelabs.ru/fbsd/patches/drm2/fix-drm_drv-off-by-one-v2.diff. >=20 > What do you think? I think that the original one-liner is fine, and this one is overcomplicati= on. --=20 You are receiving this mail because: You are on the CC list for the bug.=