From owner-freebsd-fs@FreeBSD.ORG  Thu Aug  7 23:30:03 2008
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E108B106566B
	for <freebsd-fs@hub.freebsd.org>; Thu,  7 Aug 2008 23:30:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id CDEED8FC0A
	for <freebsd-fs@hub.freebsd.org>; Thu,  7 Aug 2008 23:30:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m77NU3kg052288
	for <freebsd-fs@freefall.freebsd.org>; Thu, 7 Aug 2008 23:30:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m77NU3GP052285;
	Thu, 7 Aug 2008 23:30:03 GMT (envelope-from gnats)
Date: Thu, 7 Aug 2008 23:30:03 GMT
Message-Id: <200808072330.m77NU3GP052285@freefall.freebsd.org>
To: freebsd-fs@FreeBSD.org
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
Cc: 
Subject: Re: kern/126287: [ufs] [panic] Kernel panics while mounting an UFS
	filesystem with snapshot enabled
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Aug 2008 23:30:04 -0000

The following reply was made to PR kern/126287; it has been noted by GNATS.

From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Kostik Belousov <kostikbel@gmail.com>
Cc: Mateusz Guzik <mjguzik@gmail.com>,  freebsd-fs@freebsd.org,  bug-followup@freebsd.org
Subject: Re: kern/126287: [ufs] [panic] Kernel panics while mounting an UFS filesystem with snapshot enabled
Date: Fri, 08 Aug 2008 01:09:11 +0200

 Kostik Belousov <kostikbel@gmail.com> writes:
 > @@ -169,7 +169,8 @@ ffs_mount(struct mount *mp, struct thread *td)
 >  		 * persist "snapshot" in the options list.
 >  		 */
 >  		vfs_deleteopt(mp->mnt_optnew, "snapshot");
 > -		vfs_deleteopt(mp->mnt_opt, "snapshot");
 > +		if (mp->mnt_opt !=3D NULL)
 > +			vfs_deleteopt(mp->mnt_opt, "snapshot");
 >  	}
 >=20=20
 >  	MNT_ILOCK(mp);
 
 I would suggest also adding a KASSERT to vfs_deleteopt().
 
 DES
 --=20
 Dag-Erling Sm=C3=B8rgrav - des@des.no