From owner-svn-src-head@freebsd.org Tue Jan 3 15:52:12 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 14AF7C9D3DF for ; Tue, 3 Jan 2017 15:52:12 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E249B1DC7 for ; Tue, 3 Jan 2017 15:52:11 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: 8aaf21d1-d1cc-11e6-acc0-c7e6c9ad01d6 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.78.92.27 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.78.92.27]) by outbound2.ore.mailhop.org (Halon) with ESMTPSA id 8aaf21d1-d1cc-11e6-acc0-c7e6c9ad01d6; Tue, 03 Jan 2017 15:51:51 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id v03Fq3vN000939; Tue, 3 Jan 2017 08:52:03 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1483458723.16152.107.camel@freebsd.org> Subject: Re: svn commit: r311109 - head/usr.bin/patch From: Ian Lepore To: Konstantin Belousov , Pedro Giffuni Cc: Conrad Meyer , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Tue, 03 Jan 2017 08:52:03 -0700 In-Reply-To: <20170103102622.GO1923@kib.kiev.ua> References: <201701021823.v02INWXc028047@repo.freebsd.org> <9c3fc378-ee5e-19ba-c286-1440d4b13615@FreeBSD.org> <20170103102622.GO1923@kib.kiev.ua> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jan 2017 15:52:12 -0000 On Tue, 2017-01-03 at 12:26 +0200, Konstantin Belousov wrote: > On Mon, Jan 02, 2017 at 07:41:26PM -0500, Pedro Giffuni wrote: > > > > > > > > On 01/02/17 17:54, Conrad Meyer wrote: > > > > > > I was suggesting using UINT32_MAX/2 on all platforms (which is > > > safe > > > everywhere). > > > > > Ah OK. INT_MAX is ~ (UINT_MAX / 2) so it's the same to use either. > > I just think it's clearer to use INT_MAX and the corresponding int > > type. > > > > The other issue is if diff(1) can handle such lines(?). > Of course it cannot, on ILP32 arches. > I kind of don't understand the premise of the naysayers in this thread.  Some machines cannot do lines that are UINT_MAX long, so in that case we should not support any lines longer than USHORT_MAX?  As if there aren't *billions* of line length limits to choose from between those two numbers? I'm also trying to picture the real-world need to diff and patch lines of ascii text longer than 64K, but for every problem out there, there is someone with a perverse need to solve that problem outside of the normal lines we all live between. -- Ian