Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 6 Dec 2025 07:52:23 +0100 (CET)
From:      Ronald Klop <ronald-lists@klop.ws>
To:        Rick Macklem <rick.macklem@gmail.com>
Cc:        =?UTF-8?Q?Gerrit_K=C3=BChn?= <gerrit.kuehn@aei.mpg.de>, void <void@f-m.fm>, freebsd-fs@freebsd.org
Subject:   Re: nfs exports by local dns
Message-ID:  <254762252.11873.1765003943072@localhost>
In-Reply-To: <CAM5tNy5XzAHMCFuS1UJ1Gjke0EsaqnY6W6e-LLfSdS8AiEHOnQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
Rick,

Would you like to close the review? As this is committed already. 

https://reviews.freebsd.org/D45814




Regards,

Ronald




Van: Rick Macklem <rick.macklem@gmail.com>
Datum: 5 december 2025 16:23
Aan: "Gerrit Kühn" <gerrit.kuehn@aei.mpg.de>
CC: void <void@f-m.fm>, freebsd-fs@freebsd.org
Onderwerp: Re: nfs exports by local dns

> 
> 
> On Fri, Dec 5, 2025 at 7:17AM Rick Macklem  wrote:
> >
> > On Fri, Dec 5, 2025 at 6:06AM Gerrit Kühn  wrote:
> > >
> > > Am Fri, 5 Dec 2025 13:35:17 +0000
> > > schrieb void :
> > >
> > > > the short form hostname seems to work well in the zfs sharenfs line
> > > > but I've not needed to try yet to split it over long lines with
> > > > backslash
> > >
> > > Thanks for sharing your experience.
> > > Your lines above remind me of the long-standing issue that there is no
> > > easy way to have sharenfs produce multiple lines in the exports file. Upon
> > > reviewing the situation, I found that there has been a patch for this
> > > (already in summer 2024): https://reviews.freebsd.org/D45814
> > > It has even been merged to the openzfs
> > > repo: https://github.com/openzfs/zfs/pull/16338
> > >
> > > Is there some easy way to find out where a particular patch like this went
> > > in the FreeBSD git repo (i.e., which release might have it)? I thought
> > > this should be easy to tell, but so far I was not able to find out how.
> > > It looks like it did not make it into 14.3 (but maybe 15.0?).
> > Just look at the history for the same file in FreeBSD's repo.
> > (In this case: sys/contrib/openzfs/lib/libshare/os/freebsd/nfs.c)
> > You have to click on the commit (in this case ce4dcb9) to see the
> > list of OpenZFS commits pulled.
> >
> > It was committed to main in Aug. 10, 2024 as a part of ce4dcb9
> One thing I will note is that it did take me a looonnggg time to get
> around to doing this.
> 
> If anyone has a patch for ZFS, they can set it up as a pull request
> for OpenZFS on github. They do not need to be a FreeBSD committer.
> (Once reviewed/pulled by OpenZFS it will find its way into FreeBSD.)
> 
> rick
> 
> >
> > rick
> >
> > >
> > >
> > > cu
> > >   Gerrit
> 
> 
> 
> 
> 
[-- Attachment #2 --]
<html><head></head><body>Rick,<div><br></div><div>Would you like to close the review? As this is committed already.&nbsp;</div><div><br></div><div><p style="margin: 0px; font-style: normal; font-variant-caps: normal; font-width: normal; font-size: 12px; line-height: normal; font-family: Helvetica; font-size-adjust: none; font-kerning: auto; font-variant-alternates: normal; font-variant-ligatures: normal; font-variant-numeric: normal; font-variant-east-asian: normal; font-variant-position: normal; font-variant-emoji: normal; font-feature-settings: normal; font-optical-sizing: auto; font-variation-settings: normal;"><a href="https://reviews.freebsd.org/D45814">https://reviews.freebsd.org/D45814</a></p><p style="margin: 0px; font-style: normal; font-variant-caps: normal; font-width: normal; font-size: 12px; line-height: normal; font-family: Helvetica; font-size-adjust: none; font-kerning: auto; font-variant-alternates: normal; font-variant-ligatures: normal; font-variant-numeric: normal; font-variant-east-asian: normal; font-variant-position: normal; font-variant-emoji: normal; font-feature-settings: normal; font-optical-sizing: auto; font-variation-settings: normal;"><br></p><p style="margin: 0px; font-style: normal; font-variant-caps: normal; font-width: normal; font-size: 12px; line-height: normal; font-family: Helvetica; font-size-adjust: none; font-kerning: auto; font-variant-alternates: normal; font-variant-ligatures: normal; font-variant-numeric: normal; font-variant-east-asian: normal; font-variant-position: normal; font-variant-emoji: normal; font-feature-settings: normal; font-optical-sizing: auto; font-variation-settings: normal;">Regards,</p><p style="margin: 0px; font-style: normal; font-variant-caps: normal; font-width: normal; font-size: 12px; line-height: normal; font-family: Helvetica; font-size-adjust: none; font-kerning: auto; font-variant-alternates: normal; font-variant-ligatures: normal; font-variant-numeric: normal; font-variant-east-asian: normal; font-variant-position: normal; font-variant-emoji: normal; font-feature-settings: normal; font-optical-sizing: auto; font-variation-settings: normal;">Ronald</p><p style="margin: 0px; font-style: normal; font-variant-caps: normal; font-width: normal; font-size: 12px; line-height: normal; font-family: Helvetica; font-size-adjust: none; font-kerning: auto; font-variant-alternates: normal; font-variant-ligatures: normal; font-variant-numeric: normal; font-variant-east-asian: normal; font-variant-position: normal; font-variant-emoji: normal; font-feature-settings: normal; font-optical-sizing: auto; font-variation-settings: normal;"><br></p><p><small><strong>Van:</strong> Rick Macklem &lt;rick.macklem@gmail.com&gt;<br><strong>Datum:</strong> 5 december 2025 16:23<br><strong>Aan:</strong> "Gerrit Kühn" &lt;gerrit.kuehn@aei.mpg.de&gt;<br><strong>CC:</strong> void &lt;void@f-m.fm&gt;, freebsd-fs@freebsd.org<br><strong>Onderwerp:</strong> Re: nfs exports by local dns<br></small></p><blockquote style="margin-left: 5px; border-left: 3px solid #ccc; margin-right: 0px; padding-left: 5px;"><div class="MessageRFC822Viewer do_not_remove" id="P"><!-- P -->
<!-- processMimeMessage --><div class="TextPlainViewer do_not_remove" id="P.P"><!-- P.P -->On Fri, Dec 5, 2025 at 7:17AM Rick Macklem <rick.macklem@gmail.com> wrote:<br>
&gt;<br>
&gt; On Fri, Dec 5, 2025 at 6:06AM Gerrit Kühn <gerrit.kuehn@aei.mpg.de> wrote:<br>
&gt; &gt;<br>
&gt; &gt; Am Fri, 5 Dec 2025 13:35:17 +0000<br>
&gt; &gt; schrieb void <void@f-m.fm>:<br>
&gt; &gt;<br>
&gt; &gt; &gt; the short form hostname seems to work well in the zfs sharenfs line<br>
&gt; &gt; &gt; but I've not needed to try yet to split it over long lines with<br>
&gt; &gt; &gt; backslash<br>
&gt; &gt;<br>
&gt; &gt; Thanks for sharing your experience.<br>
&gt; &gt; Your lines above remind me of the long-standing issue that there is no<br>
&gt; &gt; easy way to have sharenfs produce multiple lines in the exports file. Upon<br>
&gt; &gt; reviewing the situation, I found that there has been a patch for this<br>
&gt; &gt; (already in summer 2024): <a href="https://reviews.freebsd.org/D45814">https://reviews.freebsd.org/D45814</a><br>;
&gt; &gt; It has even been merged to the openzfs<br>
&gt; &gt; repo: <a href="https://github.com/openzfs/zfs/pull/16338">https://github.com/openzfs/zfs/pull/16338</a><br>;
&gt; &gt;<br>
&gt; &gt; Is there some easy way to find out where a particular patch like this went<br>
&gt; &gt; in the FreeBSD git repo (i.e., which release might have it)? I thought<br>
&gt; &gt; this should be easy to tell, but so far I was not able to find out how.<br>
&gt; &gt; It looks like it did not make it into 14.3 (but maybe 15.0?).<br>
&gt; Just look at the history for the same file in FreeBSD's repo.<br>
&gt; (In this case: sys/contrib/openzfs/lib/libshare/os/freebsd/nfs.c)<br>
&gt; You have to click on the commit (in this case ce4dcb9) to see the<br>
&gt; list of OpenZFS commits pulled.<br>
&gt;<br>
&gt; It was committed to main in Aug. 10, 2024 as a part of ce4dcb9<br>
One thing I will note is that it did take me a looonnggg time to get<br>
around to doing this.<br>
<br>
If anyone has a patch for ZFS, they can set it up as a pull request<br>
for OpenZFS on github. They do not need to be a FreeBSD committer.<br>
(Once reviewed/pulled by OpenZFS it will find its way into FreeBSD.)<br>
<br>
rick<br>
<br>
&gt;<br>
&gt; rick<br>
&gt;<br>
&gt; &gt;<br>
&gt; &gt;<br>
&gt; &gt; cu<br>
&gt; &gt; &nbsp;&nbsp;Gerrit<br>
<br>
</void@f-m.fm></gerrit.kuehn@aei.mpg.de></rick.macklem@gmail.com></div><!-- TextPlainViewer -->
<hr>
</div><!-- MessageRFC822Viewer -->
</blockquote><br><br><br></div></body></html>

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?254762252.11873.1765003943072>